-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: provide guidance on shared workspaces #21214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcjiang
wants to merge
11
commits into
main
Choose a base branch
from
shared-workspaces-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−0
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
31b6f0c
first draft of shared workspaces page
jcjiang 14ee9b2
Merge branch 'main' into shared-workspaces-docs
jcjiang 81ecf0e
Update docs/user-guides/workspaces-shared.md
jcjiang 85ac594
Update docs/user-guides/workspaces-shared.md
jcjiang 55fa18c
Update docs/user-guides/workspaces-shared.md
jcjiang beb5adb
Update docs/user-guides/workspaces-shared.md
jcjiang a1450ae
Update docs/user-guides/workspaces-shared.md
jcjiang 3b661d2
Update docs/user-guides/workspaces-shared.md
jcjiang 589a651
added beta tag
jcjiang 8f030be
Merge branch 'main' into shared-workspaces-docs
jcjiang adc795d
changed file names
jcjiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update docs/user-guides/workspaces-shared.md
Co-authored-by: ケイラ <mckayla@hey.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure code review is really a use case people will want from shared workspaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, will take it out - took it from Notion's sum-up without thinking too hard about it, but your point makes sense