Skip to content

Conversation

@bpmct
Copy link
Member

@bpmct bpmct commented Dec 9, 2025

Command apps (terminal apps with command field) were being filtered out from the Tasks view because they have health "disabled" when no healthcheck is defined.

Updated the filter in TaskApps.tsx to allow command apps through regardless of health status so they appear as tabs alongside web apps.

Screenshot 2025-12-08 at 8 10 47 PM

Closes #21183

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Copy link
Member Author

bpmct commented Dec 9, 2025

Worth noting there's an alternate approach here - we could fix this on the backend instead.

Right now command apps get health "disabled" when they don't have a healthcheck, which is why they're being filtered out. We could change the backend to set their health to something else (maybe "healthy" or "not-applicable") since "disabled" is kind of misleading for apps that just don't have healthchecks.

That would keep the frontend filter simple, but would need backend changes and maybe a migration. This frontend fix is easier and more localized though.

Open to thoughts on which makes more sense.

@bpmct bpmct requested a review from DanielleMaywood December 9, 2025 02:03
@bpmct bpmct marked this pull request as ready for review December 9, 2025 02:11
@bpmct bpmct requested a review from aslilac December 9, 2025 02:11
Previously, command apps (apps with `command` field instead of `url`) were
filtered out from the Tasks view because they had health "disabled" when no
healthcheck was defined.

This change updates the filter to allow command apps through regardless of
their health status, so they appear as tabs in the Tasks view alongside web
apps and the generic terminal.

Fixes #21183

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@bpmct bpmct force-pushed the fix/issue-21183-show-command-apps-in-tasks-view branch from c2a5718 to b2909b9 Compare December 9, 2025 14:54
@bpmct bpmct requested a review from DanielleMaywood December 9, 2025 14:54
@bpmct bpmct merged commit f6b025e into main Dec 9, 2025
29 of 31 checks passed
@bpmct bpmct deleted the fix/issue-21183-show-command-apps-in-tasks-view branch December 9, 2025 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command apps (terminal apps) don't show up in Tasks view

3 participants