feat(site): add cmd+enter to submit tasks immediately #21182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b95d53 to
c5fd1d2
Compare
Member
Author
|
I have confirmed this works! |
DanielleMaywood
requested changes
Dec 9, 2025
Implements cmd+enter (Mac) / ctrl+enter (Windows/Linux) keyboard shortcut for submitting new tasks on the tasks page. Regular enter still creates a new line in the textarea. Fixes #21179 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
c5fd1d2 to
802cb42
Compare
As suggested by @aslilac, pass the onSubmit handler directly as a prop rather than querying the DOM with closest('form'). This is more idiomatic React and keeps the logic within React's declarative paradigm.
DanielleMaywood
requested changes
Dec 9, 2025
Member
Author
|
Cool, edited and confirmed this still works. |
Contributor
DanielleMaywood
left a comment
There was a problem hiding this comment.
Just a couple of comments, after that I think we'll be there!
bpmct
added a commit
that referenced
this pull request
Dec 10, 2025
When working on PRs, Claude Code was sometimes force pushing to branches. This adds simple git workflow guidelines emphasizing: - Check out PR branches properly (fetch, checkout, pull) - Don't use git push --force unless explicitly requested Examples of PRs with multiple commits from iterative work: - #21148: 7 commits including merge commit - #21150: 9 commits with iterative documentation changes - #21182: 4 commits with fixes - Also observed force updates on feat/add-tasks-template-flag branch 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove custom onFormSubmit prop from PromptTextarea - Remove duplicate e.preventDefault() call - Use existing onKeyDown prop from TextareaAutosizeProps - Submit form via form.requestSubmit() instead of calling handler directly
DanielleMaywood
approved these changes
Dec 10, 2025
| const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => { | ||
| // Submit form on Cmd+Enter (Mac) or Ctrl+Enter (Windows/Linux) | ||
| if (e.key === "Enter" && (e.metaKey || e.ctrlKey)) { | ||
| e.preventDefault(); |
Contributor
There was a problem hiding this comment.
Suggested change
| e.preventDefault(); |
No need for this as onSubmit handles it but otherwise LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements cmd+enter (Mac) / ctrl+enter (Windows/Linux) keyboard shortcut for submitting tasks on the tasks page. Regular enter key still creates new lines as expected.
Fixes #21179
🤖 Generated with Claude Code