-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: restructure dev container documentation #21157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e7dac02 to
0ebab5c
Compare
📚 Documentation Check✨ No Changes NeededReason: This PR is a documentation-only restructure that successfully reorganizes dev containers documentation. All documentation has been properly updated in this PR. What was done:
The restructure improves discoverability by consolidating both dev containers approaches under a dedicated integrations section, with clear guidance on when to use each approach. This comment was generated by an AI Agent through Coder Tasks |
85609ac to
e51d282
Compare
Dev container admin docs were scattered across two locations: the Docker-based
integration under extending-templates/ and Envbuilder under managing-templates/.
There was no landing page explaining that two approaches exist or helping admins
choose between them.
This moves everything under admin/integrations/devcontainers/ with a decision
guide at the top. Dev containers are an integration with the dev container
specification, so integrations/ is a natural fit alongside JFrog, Vault, etc.
Stub pages remain at the original locations for discoverability.
New structure:
admin/integrations/devcontainers/
├── index.md # Landing page + decision guide
├── integration.md # Docker-based dev containers
└── envbuilder/
├── index.md
├── add-envbuilder.md
├── envbuilder-security-caching.md
└── envbuilder-releases-known-issues.md
Refs #21080
e51d282 to
9fae08a
Compare
david-fraley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level looks good. Can you head to the preview links, and make sure all the pages render A-OK including the various page links and !notes you have?
Also, consider adding in some pics to show what Devcontainers actually looks like when setup and running in the UI!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is just a little restructuring I'm happy with approving this. We can resolve any issues with the existing documentation in a follow-up PR
@david-fraley What does "preview links" refer to? If we have a way to view docs from PR I'm happy to take a look, but I'm not aware of it. There aren't a whole lot of |
Let's plan some follow-up changes and keep this PR scoped to restructuring.
@mafredri basically me being nervous of another 404 situation. We should be fine |
@david-fraley Gotcha. Full disclosure I took a risk in coder/coder.com#524 and updated the redirects directly without creating yet another set of redirects, so if someone bookmarked certain Envbuilder docs between Saturday and today, they'll get 404's. 😔 I chose simplicity over covering this minimal edge-case. |
Dev container admin docs were scattered across two locations: the Docker-based
integration under
extending-templates/and Envbuilder undermanaging-templates/.There was no landing page explaining that two approaches exist or helping admins
choose between them.
This moves everything under
admin/integrations/devcontainers/with a decisionguide at the top. Dev containers are an integration with the dev container
specification, so
integrations/is a natural fit alongside JFrog, Vault, etc.Stub pages remain at the original locations for discoverability.
New structure:
Refs #21080