test: bump TestAgent_SessionTTYShell timeout #21155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was using WaitShort (10s) for the context timeout when waiting for the shell prompt via Peek(ctx, 1). On slow macOS CI runners, the shell startup can exceed this timeout due to resource contention. Increase to WaitMedium (30s) to match the timeout used by ExpectMatch internally, giving the shell more time to initialize.
deansheather
approved these changes
Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
TestAgent_SessionTTYShelltest was flaking on macOS CI runners with:The test uses
WaitShort(10s) for the context timeout when waiting for shell prompt output viaPeek(ctx, 1). On slow macOS CI runners, the shell startup can exceed this timeout due to resource contention.This is evidenced in the failure logs, the SSH session was not reported by the agent until the 10s timeout is nearly up - it took a while to connect.
Solution
Increase the timeout from
WaitShort(10s) toWaitMedium(30s). This matches the timeout used byExpectMatchinternally and gives the shell more time to initialize on slow CI machines.This PR was entirely generated by mux but reviewed by a human.
Closes coder/internal#1177