fix(coderd): exclude sub-agents from workspace health calculation #21098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a devcontainer was rebuilding, its sub-agent would become temporarily disconnected, causing the workspace to show as unhealthy. This was confusing because the workspace itself was fine. Sub-agents (agents with a ParentID) are now excluded from the workspace health calculation. Their health is managed by their parent agent, and temporary disconnections during devcontainer rebuilds should not affect the overall workspace health status.
3e94111 to
67ead3a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a devcontainer rebuilds, its sub-agent temporarily disconnects, causing the workspace to show as unhealthy.
This is a simplistic fix that excludes sub-agents from the workspace health calculation entirely. Ideally we'd only exclude them during rebuilds, but showing a healthy workspace inaccurately is less harmful than the current confusing UX.