Skip to content

chore: upgrade bundled terraform binary version #21092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdomeracki-coder merged 9 commits into from
Dec 9, 2025
Merged

chore: upgrade bundled terraform binary version #21092

jdomeracki-coder merged 9 commits into from
Dec 9, 2025

Conversation

@jdomeracki-coder
Copy link
Contributor

@jdomeracki-coder jdomeracki-coder commented Dec 4, 2025

@matifali matifali added the doc-check Assign this label to PRs to check for any doc changes. label Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Task created: https://dev.coder.com/tasks/matifali/3b95363d-a754-4f12-a627-4fdbc91d1559

@matifali Coder
Copy link
Member

matifali commented Dec 4, 2025

📚 Documentation Check

✅ Updates Needed

  • docs/install/airgap.md - Update example TERRAFORM_VERSION from 1.11.0 to 1.14.1 to match the new default version

📝 Optional Updates

  • docs/admin/integrations/opentofu.md - The hardcoded GitHub link to install.go could be updated to reflect the new version range (currently points to an old commit), though this link naturally updates with the main branch

Summary

This PR upgrades Terraform from 1.13.4 to 1.14.1 across three key files:

  • provisioner/terraform/install.go (default version + max supported version)
  • scripts/Dockerfile.base (base image Terraform version)
  • install.sh (installation script default version)

The air-gapped deployment documentation includes a Dockerfile example that specifies TERRAFORM_VERSION=1.11.0. While this is marked as an optional override, it should be updated to reflect the new default version (1.14.1) to maintain consistency and ensure users following the example get the officially supported version.

This comment was generated by an AI Agent through Coder Tasks

@spikecurtis
Copy link
Contributor

spikecurtis commented Dec 4, 2025

Also needs make gen I think.

@spikecurtis spikecurtis self-requested a review December 4, 2025 12:27
@jdomeracki-coder
Copy link
Contributor Author

jdomeracki-coder commented Dec 8, 2025

Observing following test failures:
https://github.com/coder/coder/actions/runs/20022892746/job/57413599902#step:8:544

coder/provisioner/terraform/resources_test.go

Line 373 in 25400fe

"multiple-agents-multiple-monitors": { 

=== Failed
=== FAIL: provisioner/terraform TestConvertResources/multiple-agents-multiple-monitors/Provision (0.01s)
    resources_test.go:1065: 
        	Error Trace:	/home/runner/work/coder/coder/provisioner/terraform/resources_test.go:1065
        	Error:      	unexpected resources
        	Test:       	TestConvertResources/multiple-agents-multiple-monitors/Provision
        	Messages:   	diff (-want +got):
        	            	  []map[string]any{
        	            	  	{
        	            	  		"agents": []any{
        	            	  			map[string]any{
        	            	  				"Auth":          map[string]any{"Token": string("")},
        	            	- 				"api_key_scope": string("all"),
        	            	  				"apps":          []any{map[string]any{"display_name": string("app1"), "open_in": float64(1), "slug": string("app1")}, map[string]any{"display_name": string("app2"), "healthcheck": map[string]any{"interval": float64(5), "threshold": float64(6), "url": string("http://localhost:13337/healthz")}, "open_in": float64(1), "slug": string("app2"), ...}},
        	            	  				"architecture":  string("amd64"),
        	            	  				... // 5 identical entries
        	            	  			},
        	            	  			map[string]any{
        	            	  				"Auth":                       map[string]any{"Token": string("")},
        	            	- 				"api_key_scope":              string("all"),
        	            	  				"architecture":               string("amd64"),
        	            	  				"connection_timeout_seconds": float64(120),
        	            	  				... // 4 identical entries
        	            	  			},
        	            	  		},
        	            	  		"name": string("dev"),
        	            	  		"type": string("null_resource"),
        	            	  	},
        	            	  }

=== FAIL: provisioner/terraform TestConvertResources/multiple-agents-multiple-monitors/Plan (0.02s)
    t.go:106: 2025-12-08 09:25:27.315 [warn]  coder_app's id was unexpectedly empty  name=""
    t.go:106: 2025-12-08 09:25:27.316 [warn]  coder_app's id was unexpectedly empty  name=""
    resources_test.go:1003: 
        	Error Trace:	/home/runner/work/coder/coder/provisioner/terraform/resources_test.go:1003
        	Error:      	unexpected resources
        	Test:       	TestConvertResources/multiple-agents-multiple-monitors/Plan
        	Messages:   	diff (-want +got):
        	            	  []map[string]any{
        	            	  	{
        	            	  		"agents": []any{
        	            	  			map[string]any{
        	            	  				"Auth":          map[string]any{"Token": string("")},
        	            	- 				"api_key_scope": string("all"),
        	            	  				"apps":          []any{map[string]any{"display_name": string("app1"), "open_in": float64(1), "slug": string("app1")}, map[string]any{"display_name": string("app2"), "healthcheck": map[string]any{"interval": float64(5), "threshold": float64(6), "url": string("http://localhost:13337/healthz")}, "open_in": float64(1), "slug": string("app2"), ...}},
        	            	  				"architecture":  string("amd64"),
        	            	  				... // 5 identical entries
        	            	  			},
        	            	  			map[string]any{
        	            	  				"Auth":                       map[string]any{"Token": string("")},
        	            	- 				"api_key_scope":              string("all"),
        	            	  				"architecture":               string("amd64"),
        	            	  				"connection_timeout_seconds": float64(120),
        	            	  				... // 4 identical entries
        	            	  			},
        	            	  		},
        	            	  		"name": string("dev"),
        	            	  		"type": string("null_resource"),
        	            	  	},
        	            	  }

=== FAIL: provisioner/terraform TestConvertResources/multiple-agents-multiple-monitors (0.00s)

=== FAIL: provisioner/terraform TestConvertResources (0.00s)

@deansheather deansheather force-pushed the terraform-version-upgrade-1.14.1 branch from 5fe4eb9 to 7311b58 Compare December 9, 2025 11:00
@jdomeracki-coder jdomeracki-coder merged commit b04e687 into main Dec 9, 2025
34 of 36 checks passed
@jdomeracki-coder jdomeracki-coder deleted the terraform-version-upgrade-1.14.1 branch December 9, 2025 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@jdomeracki-coder jdomeracki-coder

Labels

doc-check Assign this label to PRs to check for any doc changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdomeracki-coder @matifali @spikecurtis @deansheather