fix: fixes use of possibly nil RemoteAddr() and LocalAddr() return values #21076
+94
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
spikecurtis
commented
Dec 3, 2025
dannykopping
approved these changes
Dec 3, 2025
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
LGTM
Nice touch with the linter, although I have a mild concern that it's not specific to the net.Addr type so it may result in false-positives.
d45d7e2 to
d025d32
Compare
Contributor
Author
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: coder/internal#1143
Both gVisor and the Go standard library implementations of
net.Conncan under certain circumstances returnnilforRemoteAddr()andLocalAddr()calls. If we call their methods, we segfault.This PR fixes these calls and adds ruleguard rules.
Note that
slog.F("remote_addr", conn.RemoteAddr())is fine because slog detects thenilbefore attempting to stringify the type.