fix: pass context with authorization to agentapi #20959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authorization attached to it via the context so that the cache refresh routine can fetch the workspace from the db via GetWorkspaceForAgentID Signed-off-by: Callum Styan <callumstyan@gmail.com>
Emyrk
reviewed
Nov 26, 2025
coderd/workspaceagentsrpc.go
Outdated
| OrganizationID: workspace.OrganizationID, | ||
|
|
||
| Ctx: api.ctx, | ||
| Ctx: ctx, |
Member
There was a problem hiding this comment.
I think this context is only used in startCacheRefreshLoop?
If so, we can rename Ctx to like AuthenticatedCtx or something akin to that? So users of it know what it carries?
Contributor
Author
There was a problem hiding this comment.
You're right, it's not passed to any of the sub API's and afaict none of the other functions directly on the API use it either.
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Emyrk
reviewed
Nov 26, 2025
coderd/agentapi/api.go
Outdated
| // This ensures that changes like prebuild claims (which modify owner_id, name, etc.) | ||
| // are eventually reflected in the cache without requiring agent reconnection. | ||
| func (a *API) refreshCachedWorkspace(ctx context.Context) { | ||
| a.opts.Log.Debug(ctx, "refreshing cached workspace", slog.F("test", "test")) |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Emyrk
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agentapi context needs to be a context with some amount of authorization attached to it via the context so that the cache refresh routine can fetch the workspace from the db via GetWorkspaceForAgentID.