Skip to content

Conversation

@ssncferreira
Copy link
Contributor

@ssncferreira ssncferreira commented Nov 26, 2025

Description

Update task topbar in task page to show display name, instead of task name.

Follow-up PR: #20918
Related to internal slack thread: https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829

</TooltipProvider>

<h1 className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1>
<h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just defaulting to the same value as in the Tasks list view. In the backend, we also always guarantee that the display name is only 64 characters, which should not reach this maximum.

@ssncferreira ssncferreira marked this pull request as ready for review November 26, 2025 19:56
@DanielleMaywood
Copy link
Contributor

When given a long task name, it causes these two buttons to touch

SCR-20251127-jstu

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ssncferreira
Copy link
Contributor Author

When given a long task name, it causes these two buttons to touch

SCR-20251127-jstu

Nice catch 👀 Addressed in: 2b64a2e with some styling changes, but not sure if it is the best way

</TooltipProvider>

<h1 className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1>
<h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate">
<h1 className="m-0 pl-2 text-base font-medium max-w-[64ch] truncate">

We talked about this during our chat, unsure if we do this pattern elsewhere but it might look less magic to someone reading in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, it looks like this doesn’t exactly meet the 64-characters, which leads to the page width expanding, which isn’t ideal 🙁

@ssncferreira ssncferreira merged commit 21efebe into main Nov 27, 2025
31 checks passed
@ssncferreira ssncferreira deleted the ssncferreira/fix-task-topbar-display-name branch November 27, 2025 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
@ssncferreira ssncferreira added cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch and removed cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch labels Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants