fix: update colors and theme in error.html
#20941
Conversation
aslilac
left a comment
There was a problem hiding this comment.
the color changes seem fine but I'm not sure about using rem as units. they're a lot less intuitive than pixels imo.
|
|
||
| .container { | ||
| --side-padding: 24px; | ||
| --side-padding: 1.5rem; |
There was a problem hiding this comment.
why rem? afaik we don't currently use those anywhere
There was a problem hiding this comment.
Aren't we using this more globally now with rem being the standard unit in Tailwind? I thought it might be good to keep it better inline with that, happy to undo this change though
There was a problem hiding this comment.
From looking into Tailwind, it is based on Rem so using this would be more consistent and be better for matching the users font size. We Could use Tailwind in this file as well by using a CDN or the Tailwind cli to process this file. Not sure it's worth the trouble.
|
Can you include a screenshot in the PR description of how the error page looks? |
Description
This pull-request ensures that we're using the right colors (and themeing things within the actual coder brand) on the
error.htmlpage. Furthermore, I went ahead and cleaned up the CSS Variables and converted allpxunits to a standardremunit (16px base).Preview