Skip to content

refactor: replace remaining MUI tooltips #20938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aqandrew wants to merge 12 commits into
base: main
Choose a base branch
from
+210 −144
Open

refactor: replace remaining MUI tooltips #20938

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad618ca
refactor: replace MUI tooltip in RichParameterInput
aqandrew Nov 25, 2025
b5dab33
refactor: replace MUI tooltips whose content is JSX
aqandrew Nov 26, 2025
dd32f75
refactor: replace MUI tooltip in EditRolesButton
aqandrew Nov 26, 2025
0c52ea2
fix: make WorkspaceScheduleControls' trigger name the same as its
aqandrew Nov 26, 2025
5b98d0c
feat: set max width for AppLink tooltip
aqandrew Dec 3, 2025
45ea289
refactor: replace MUI tooltip in UserRoleCell
aqandrew Dec 4, 2025
6669eb4
test: configure test user to show OverflowRolePill containing global
aqandrew Dec 4, 2025
746b416
refactor: replace nested MUI tooltip in OverflowRolePill
aqandrew Dec 4, 2025
1c3c154
Merge branch 'main' into aqandrew/replace-remaining-mui-tooltips
aqandrew Dec 4, 2025
afb0546
Merge branch 'main' into aqandrew/replace-remaining-mui-tooltips
aqandrew Dec 9, 2025
74ff421
chore: uncomment MUI tooltip deprecation warning
aqandrew Dec 10, 2025
a093afa
Merge branch 'main' into aqandrew/replace-remaining-mui-tooltips
aqandrew Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: replace MUI tooltip in UserRoleCell
  • Loading branch information
@aqandrew
aqandrew committed Dec 4, 2025
commit 45ea289efc71440b15b3b5112e84f75da08958c7
11 changes: 8 additions & 3 deletions site/src/pages/OrganizationSettingsPage/UserTable/UserRoleCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,14 @@ export const UserRoleCell: FC<UserRoleCellProps> = ({
}
>
{mainDisplayRole.global ? (
<MUITooltip title="This user has this role for all organizations.">
<span>{displayName}*</span>
</MUITooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>{displayName}*</span>
</TooltipTrigger>
<TooltipContent side="bottom" sideOffset={8}>
This user has this role for all organizations.
</TooltipContent>
</Tooltip>
) : (
displayName
)}
Expand Down