Skip to content

fix(site): only show active tasks in waiting for input tab #20933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mafredri merged 4 commits into from
Nov 26, 2025
+42 −2
Merged

fix(site): only show active tasks in waiting for input tab #20933

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
223520f
fix(site): only show waiting for input for active tasks
mafredri Nov 26, 2025
e528432
update storybook
mafredri Nov 26, 2025
5e527db
can it be???
mafredri Nov 26, 2025
21568fc
???
mafredri Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
???
  • Loading branch information
@mafredri
mafredri committed Nov 26, 2025
commit 21568fcec5621f1bf01d69c3f791e5fae11c6181
27 changes: 15 additions & 12 deletions site/src/pages/TasksPage/TasksPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { withAuthProvider, withProxyProvider } from "testHelpers/storybook";
import type { Meta, StoryObj } from "@storybook/react-vite";
import { API } from "api/api";
import { MockUsers } from "pages/UsersPage/storybookData/users";
import { expect, spyOn, userEvent, within } from "storybook/test";
import { expect, spyOn, userEvent, waitFor, within } from "storybook/test";
import { getTemplatesQueryKey } from "../../api/queries/templates";
import TasksPage from "./TasksPage";

Expand Down Expand Up @@ -185,19 +185,22 @@ export const LoadedTasksWaitingForInputTab: Story = {
});
await userEvent.click(waitingForInputTab);

// Query within the table to check only visible rows
const table = await canvas.findByRole("table");
const tableContent = within(table);
// Wait for the table to update after tab switch
await waitFor(async () => {
const table = canvas.getByRole("table");
const tableContent = within(table);

await tableContent.findByText("Active Idle Task");
// Active idle task should be visible
expect(tableContent.getByText("Active Idle Task")).toBeInTheDocument();

// Only active idle tasks should be visible in the table
expect(
tableContent.queryByText("Paused Idle Task"),
).not.toBeInTheDocument();
expect(
tableContent.queryByText("Error Idle Task"),
).not.toBeInTheDocument();
// Only active idle tasks should be visible in the table
expect(
tableContent.queryByText("Paused Idle Task"),
).not.toBeInTheDocument();
expect(
tableContent.queryByText("Error Idle Task"),
).not.toBeInTheDocument();
});
});
},
};
Expand Down
Loading