perf(coderd/database): limit GetLatestWorkspaceAppStatusByAppID to 1 row
#20917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetLatestWorkspaceAppStatusesByAppID returned all app statuses for a given app ID, which could be unbounded for long-running AI tasks. Only the most recent status was used, so we now: - Rename query to GetLatestWorkspaceAppStatusByAppID (singular) - Change query type from :many to :one - Add LIMIT 1 to SQL query - Update usages to handle single result instead of slice Fixes #20862 --- 🤖 PR was written by Claude Sonnet 4.5 Thinking and reviewed by a human 🏄🏻♂️.
d98e3ca to
066114f
Compare
mafredri
commented
Nov 25, 2025
GetLatestWorkspaceAppStatusByAppID to 1 row
DanielleMaywood
approved these changes
Nov 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
GetLatestWorkspaceAppStatusesByAppIDreturned an unbounded number of rows for a given app ID, which could cause performance issues for noisy or long-running AI tasks.Changes
GetLatestWorkspaceAppStatusesByAppIDtoGetLatestWorkspaceAppStatusByAppID(singular):manyto:oneLIMIT 1to the SQL query to only fetch the most recent statuslen(latestAppStatus) == 0tolatestAppStatus.ID == uuid.NilImpact
This change reduces database query overhead for workspace app status updates, particularly for long-running AI tasks that update their status frequently. Previously, fetching the latest status would return all historical statuses; now it returns only the most recent one.
Fixes #20862
🤖 PR was written by Claude Sonnet 4.5 Thinking using mux and reviewed by a human 🏄🏻♂️.