Skip to content

fix: allow agents to be created on dormant workspaces #20909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielleMaywood merged 1 commit into from
Nov 25, 2025
Merged

fix: allow agents to be created on dormant workspaces #20909

DanielleMaywood merged 1 commit into from
Nov 25, 2025

Conversation

@DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Nov 25, 2025 •
edited
Loading

Closes #20711

We now allow agents to be created on dormant workspaces.

I've ran the test with and without the change. I've confirmed that - without the fix - it triggers the "rbac: unauthorized" error.

@DanielleMaywood
fix: allow agents to be created on dormant workspaces
02b26d1 
Closes #20711

We now allow agents to be created on dormant workspaces.
@DanielleMaywood DanielleMaywood marked this pull request as ready for review November 25, 2025 00:22
spikecurtis
spikecurtis approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@spikecurtis spikecurtis added cherry-pick/v2.28 Needs to be cherry-picked to the 2.28 release branch cherry-pick/v2.27 Items to be pulled in for the v2.27 release. cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch labels Nov 25, 2025 — with Graphite App
@DanielleMaywood DanielleMaywood merged commit c12303f into main Nov 25, 2025
45 checks passed
@DanielleMaywood DanielleMaywood deleted the danielle/fix/20711 branch November 25, 2025 06:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
@spikecurtis spikecurtis removed the cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch label Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels

cherry-pick/v2.27 Items to be pulled in for the v2.27 release. cherry-pick/v2.28 Needs to be cherry-picked to the 2.28 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: fail to autostop dormant workspace - RBAC error inserting agent

3 participants

@DanielleMaywood @spikecurtis