feat: add notification warning alert to Tasks page #20900

ssncferreira · 2025-11-24T14:29:00Z

Problem

Users may not realize that task notifications are disabled by default. To improve awareness, we show a warning alert on the Tasks page when all task notifications are disabled.

Alert visibility logic:

Shows when all task notification templates (Task Working, Task Idle, Task Completed, Task Failed) are disabled
Can be dismissed by the user, which stores the dismissal in the user preferences API
If the user later enables any task notification in Account Settings, the dismissal state is cleared so the alert will show again if they disable all notifications in the future

Changes

Added a warning alert to the Tasks page when all task notifications are disabled
Introduced new /users/{user}/preferences endpoint to manage user preferences (stored in user_configs table)
Alert is dismissible and stores the dismissal state via the new user preferences API endpoint
Enabling any task notification in Account Settings clears the dismissal state via the preferences API
Added comprehensive Storybook stories for both TasksPage and NotificationsPage to test all alert visibility states and interactions

Closes: coder/internal#1089

aslilac

I don't think localStorage is the right way to store the dismissal state here. I think this would be a very good candidate for storing in the user_configs table. You could follow the plumbing for theme_preference for 90% of the implementation, and then the preference would persist across machines and any potential storage clearing a browser or operating system might do.

site/src/modules/notifications/utils.tsx

site/src/pages/TasksPage/TasksPage.tsx

ssncferreira · 2025-11-25T19:55:34Z

I don't think localStorage is the right way to store the dismissal state here. I think this would be a very good candidate for storing in the user_configs table. You could follow the plumbing for theme_preference for 90% of the implementation, and then the preference would persist across machines and any potential storage clearing a browser or operating system might do.

@aslilac Thank you for the review!
I went with the localStorage approach since it’s the simplest and feels more like a frontend concern. IIUC, your suggestion is to store the dismissal state in the backend (user_configs table), but that feels unnecessary for a one-time dismissible alert. Backend storage would mainly help sync the state across devices/browsers or handle cases where users clear their browser storage, but that still seems like more complexity than this feature warrants, given that most users will most likely only see it once.

Since this is more of a transient “don’t show this again” UI state rather than a real user preference, localStorage feels like an appropriate solution for now. Maybe if users start complaining about this, this is something we can improve in the future. Does that work for you?

aslilac · 2025-11-25T22:19:10Z

that feels unnecessary for a one-time dismissible alert

but that's my point. if we don't persist this state somewhere centrally it's not "one-time". and it is a user preference: a preference to not be notified about this again. your current implementation doesn't store the preference for a specific user, it stores it for a specific browser. if you logged in with a different account it would still be dismissed.

it's not a "front-end" concern, it is a state concern.

Add comprehensive documentation for active frontend pattern migrations discovered through analysis of 200+ git commits touching site/ files: Core Migrations: - Emotion → Tailwind CSS (strict 'no new emotion' policy) - MUI Components → Custom/Radix/shadcn (Tooltips, Tables, Buttons) - MUI Icons → lucide-react with specific icon mappings - spyOn → queries parameter for GET endpoint mocks in Storybook - localStorage → user_configs table for user preferences New Documentation: - Icon migration mappings (BusinessIcon→Building2Icon, etc.) - Radix component prop naming conventions (placement→side) - cn() utility usage for conditional className merging - Chromatic testing best practices (prefer snapshots over assertions) Includes concrete before/after examples and migration patterns to guide developers away from deprecated approaches toward current best practices. Analysis based on PRs: #20948, #20946, #20938, #20905, #20900, #20869, #20849, #20808, #20530, #20479, #20261, #20201, #20200, #20193, #20318 --- 🤖 This change was written by Claude Sonnet 4.5 Thinking using mux and reviewed by a human 🏂

ssncferreira · 2025-11-26T19:35:55Z

but that's my point. if we don't persist this state somewhere centrally it's not "one-time". and it is a user preference: a preference to not be notified about this again. your current implementation doesn't store the preference for a specific user, it stores it for a specific browser. if you logged in with a different account it would still be dismissed.

That makes sense 🙂 I was thinking in terms of the user persona I assumed for Coder UI (generally using a single browser, rarely clearing storage, and not sharing that browser with others), so localStorage felt like a reasonable, lightweight option. That’s why I suggested starting simple and moving the preference into user_configs if it later turned out to cause confusion or complaints from users.

But I understand your point about this being a true user preference rather than browser-local state, and how storing it centrally avoids the cross-browser and cross-account inconsistencies you mentioned.

I’ll update the PR to persist the dismissal in user_configs.

…e-tasks-notifications-disabled

…to API

…e-tasks-notifications-disabled

mafredri

Small suggestions for BE but looks good otherwise 👍🏻

coderd/database/queries/users.sql

coderd/users_test.go

DanielleMaywood

I'm happy with what we have. Left a non-blocking nit and left a 👍 emoji on @mafredri's comments that I agree with

coderd/users_test.go

…e-tasks-notifications-disabled

mafredri

One last (minor) comment on the backend implementation, I'll submit this now and start looking at the FE changes.

coderd/users.go

mafredri

I had some minor comments, but FE looks good to me. 👍🏻

mafredri · 2025-11-28T13:46:31Z

site/src/modules/notifications/utils.tsx

 };
+
+export function isTaskNotification(tmpl: NotificationTemplate): boolean {
+	return tmpl.group === "Task Events";


(Side-note: It would be nice if we had real enums for these.)

Yeah, we are missing enums in the FE for a lot of things.

site/src/pages/TasksPage/TasksPage.tsx

mafredri · 2025-11-28T14:12:18Z

site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.tsx

+																		updatePreferencesMutation.mutate({
+																			task_notification_alert_dismissed: false,
+																		});
+																	}


Fine for now, but should we consider doing this on the backend? Ideally this change would be propagated even if done directly via API or UI (or CLI if we support that, or will support that in the future).

Yes, I also thought about that and that might be a better approach. I will address that in a follow-up PR.

github-actions bot assigned ssncferreira Nov 24, 2025

ssncferreira force-pushed the ssncferreira/feat-site-tasks-notifications-disabled branch 4 times, most recently from 104c727 to 57f4afc Compare November 25, 2025 17:33

feat: add notification warning alert to Tasks page

322c8e9

ssncferreira force-pushed the ssncferreira/feat-site-tasks-notifications-disabled branch from 57f4afc to 322c8e9 Compare November 25, 2025 17:44

ssncferreira marked this pull request as ready for review November 25, 2025 17:57

ssncferreira requested review from DanielleMaywood, aslilac and mafredri November 25, 2025 17:57

aslilac reviewed Nov 25, 2025

View reviewed changes

mafredri mentioned this pull request Nov 26, 2025

docs: document critical frontend pattern migrations in CLAUDE.md #20949

Closed

ssncferreira added 5 commits November 26, 2025 19:47

chore: address comments

834b3e8

Merge remote-tracking branch 'origin/main' into ssncferreira/feat-sit…

befbb00

…e-tasks-notifications-disabled

chore: feat: move task notification alert state from UI localStorage …

962de64

…to API

Merge remote-tracking branch 'origin/main' into ssncferreira/feat-sit…

f62e0f8

…e-tasks-notifications-disabled

chore: improve bool initialization

bea5bc4

ssncferreira requested a review from aslilac November 26, 2025 22:12

ssncferreira added 3 commits November 26, 2025 22:17

fix: TasksPage imports

b68b204

fix: dbauthz test

2a83682

Merge remote-tracking branch 'origin/main' into ssncferreira/feat-sit…

2b18742

…e-tasks-notifications-disabled

mafredri reviewed Nov 27, 2025

View reviewed changes

coderd/database/queries/users.sql Outdated Show resolved Hide resolved

coderd/database/queries/users.sql Outdated Show resolved Hide resolved

coderd/users_test.go Outdated Show resolved Hide resolved

DanielleMaywood approved these changes Nov 27, 2025

View reviewed changes

coderd/users_test.go Outdated Show resolved Hide resolved

ssncferreira added 2 commits November 28, 2025 13:09

chore: address comments

18b820f

Merge remote-tracking branch 'origin/main' into ssncferreira/feat-sit…

c3b6b01

…e-tasks-notifications-disabled

fix: fmt and lint

773b289

ssncferreira requested a review from mafredri November 28, 2025 13:31

mafredri reviewed Nov 28, 2025

View reviewed changes

coderd/users.go Outdated Show resolved Hide resolved

mafredri approved these changes Nov 28, 2025

View reviewed changes

chore: address comments

284a651

mafredri approved these changes Nov 28, 2025

View reviewed changes

ssncferreira merged commit f8d9a80 into main Nov 28, 2025
35 checks passed

ssncferreira deleted the ssncferreira/feat-site-tasks-notifications-disabled branch November 28, 2025 16:51

github-actions bot locked and limited conversation to collaborators Nov 28, 2025

ssncferreira added cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch and removed cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch labels Nov 28, 2025

feat: add notification warning alert to Tasks page #20900

feat: add notification warning alert to Tasks page #20900

Uh oh!

Conversation

ssncferreira commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Uh oh!

aslilac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssncferreira commented Nov 25, 2025

Uh oh!

aslilac commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ssncferreira commented Nov 26, 2025

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielleMaywood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

mafredri Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

ssncferreira Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mafredri Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

ssncferreira Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ssncferreira commented Nov 24, 2025 •

edited

Loading

aslilac commented Nov 25, 2025 •

edited

Loading

DanielleMaywood left a comment •

edited

Loading