Skip to content

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Nov 21, 2025

Part 1 of 2

  • this sets up the TooltipProvider for Storybook in preview.tsx and for the app in App.tsx along with removing TooltipProvider in some of the usages of Tooltip
  • I tested existing components that haven't had the TooltipProvider removed and they still function correctly. So should be fine until the 2nd PR to complete the migration.

@jaaydenh jaaydenh self-assigned this Nov 21, 2025
jaaydenh and others added 2 commits November 21, 2025 16:20
Replace MUI Tooltip with Radix Tooltip components and migrate Emotion CSS
to Tailwind utility classes. This is part of the ongoing effort to
standardize on Radix UI/shadcn components and Tailwind CSS.

Changes:
- Replace @mui/material/Tooltip with components/Tooltip/Tooltip (Radix)
- Remove unused PopperProps (not used anywhere in codebase)
- Rename placement prop to side to match Radix API
- Replace Emotion css={{ cursor: "pointer" }} with Tailwind cursor-pointer class
- Update single call site in IconsPage.tsx (placement → side)
- Wrap in TooltipProvider as required by Radix

Technical details:
- Radix uses Provider/Tooltip/Trigger/Content pattern (more verbose but flexible)
- Maintained backward compatibility for all other call sites (6 files)
- No functional changes to component behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@jaaydenh jaaydenh force-pushed the jaaydenh/global-tooltip-provider branch from e6716bc to 06cd206 Compare November 21, 2025 16:26
@jaaydenh jaaydenh requested a review from aslilac November 21, 2025 17:59
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jaaydenh jaaydenh merged commit 6c2900f into main Nov 24, 2025
33 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/global-tooltip-provider branch November 24, 2025 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants