feat(site): add startup script error alerts to Task Page #20820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8acd143 to
6d275c1
Compare
Add warning alerts to the Task Page when workspace startup scripts fail or timeout. The alerts display inline above the log viewer to maintain debugging context while providing helpful documentation links. - Create TaskStartupAlert component with error and timeout variants - Integrate alert into TaskStartingAgent component - Extend TaskPage logic to render TaskStartingAgent for error states - Add Storybook stories for component and full page integration - Follow existing pattern from TerminalAlerts component The alerts are dismissible and link to troubleshooting documentation: - /admin/templates/troubleshooting#startup-script-exited-with-an-error - /admin/templates/troubleshooting#startup-script-issues - /admin/templates/troubleshooting#your-workspace-may-be-incomplete
6d275c1 to
2be4511
Compare
mafredri
reviewed
Nov 18, 2025
…orkspace' - Update all title attributes to use sentence case (capitalize first word only) - Change 'The workspace' to 'A workspace' in alert messages
mtojek
reviewed
Nov 18, 2025
Member
mtojek
left a comment
There was a problem hiding this comment.
I'm so glad we have these cases covered with Storybook.
- Convert TaskStartupAlert from blocking banner to warning button with tooltip - Move button to topbar, positioned left of Prompt button - Change from agent-based to task.workspace_agent_lifecycle property - Remove start_error and start_timeout from blocking states - Extract shared StartupWarningButtonBase component to eliminate duplication - Update Storybook stories for new button-based UI - Users can now access full task interface during startup errors This improves UX by making startup warnings non-intrusive while still visible and accessible via hover tooltip with documentation links.
mafredri
approved these changes
Nov 19, 2025
- Renamed TaskStartupAlert.tsx to TaskStartupWarningButton.tsx to match exported component name - Changed prop from 'task: Task' to 'lifecycleState: WorkspaceAgentLifecycle | null' for cleaner API - Refactored conditional logic to use switch statement instead of if statements - Updated TaskTopbar.tsx to pass lifecycleState directly - Updated all Storybook stories to use new lifecycleState prop - Removed unnecessary MockTask dependency from stories
- Make lifecycleState parameter optional - Remove redundant early null guard (handled by switch default) - Replace MUI Link with our own Link component for consistent styling and external icon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Task page UI to show startup script errors as compact warning buttons in the topbar rather than blocking content banners.
Changes
TaskStartupWarningButton- compact amber warning button with tooltipstart_errorandstart_timeoutImplementation Details
lifecycleStateprop (focused API, easier testing)Files Modified
site/src/pages/TaskPage/TaskStartupWarningButton.tsx(new)site/src/pages/TaskPage/TaskStartupWarningButton.stories.tsx(new)site/src/pages/TaskPage/TaskTopbar.tsx(added button)site/src/pages/TaskPage/TaskPage.tsx(removed blocking states)Closes #20418