Skip to content

feat(coderd): add task prompt modification endpoint #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleMaywood merged 12 commits into from
Nov 25, 2025
+659 −37
Merged

feat(coderd): add task prompt modification endpoint #20811

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
243b4a5
feat(tasks): add task prompt modification endpoint
DanielleMaywood Nov 17, 2025
94453b4
chore: listen to feedback
DanielleMaywood Nov 18, 2025
b8d3c21
chore: oops
DanielleMaywood Nov 18, 2025
9c82a1f
chore: feedback again
DanielleMaywood Nov 20, 2025
feb5cc7
chore: address feedback
DanielleMaywood Nov 20, 2025
b12f12f
Merge branch 'main' into danielle-change-task-prompt-backend
DanielleMaywood Nov 20, 2025
36b8c78
Merge branch 'main' into danielle-change-task-prompt-backend
DanielleMaywood Nov 20, 2025
d370e3c
chore: remove jank comment, workspace -> task
DanielleMaywood Nov 24, 2025
f9749f6
chore: prompt -> input
DanielleMaywood Nov 24, 2025
fbeb95c
chore: move tests into table
DanielleMaywood Nov 24, 2025
a0e0efd
chore: oops
DanielleMaywood Nov 25, 2025
3c7204c
chore: gate on task being paused
DanielleMaywood Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: address feedback
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Nov 20, 2025
commit feb5cc76d973a6190d80f7dfc5613099dfcc781b
60 changes: 56 additions & 4 deletions coderd/aitasks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,8 @@ func TestTasks(t *testing.T) {
})
})

t.Run("UpdatePrompt", func(t *testing.T) {
t.Run("Stopped", func(t *testing.T) {
t.Run("UpdateInput", func(t *testing.T) {
t.Run("WhenPaused", func(t *testing.T) {
t.Parallel()

client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})
Expand Down Expand Up @@ -768,14 +768,19 @@ func TestTasks(t *testing.T) {
require.NoError(t, err)
require.Equal(t, codersdk.WorkspaceStatusStopped, build.Status)

// Verify task status is "Paused"
task, err = exp.TaskByID(ctx, task.ID)
require.NoError(t, err)
require.Equal(t, codersdk.TaskStatusPaused, task.Status)

// Now update prompt should succeed
err = exp.UpdateTaskInput(ctx, task.OwnerName, task.ID, codersdk.UpdateTaskInputRequest{
Input: "Updated prompt after stop",
})
require.NoError(t, err)
})

t.Run("Canceled", func(t *testing.T) {
t.Run("WhenError", func(t *testing.T) {
t.Parallel()

client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})
Expand Down Expand Up @@ -813,6 +818,11 @@ func TestTasks(t *testing.T) {
require.NoError(t, err)
require.Equal(t, codersdk.WorkspaceStatusCanceled, startBuild.Status)

// Verify task status is "Error"
task, err = exp.TaskByID(ctx, task.ID)
require.NoError(t, err)
require.Equal(t, codersdk.TaskStatusError, task.Status)

// Now update prompt should succeed
err = exp.UpdateTaskInput(ctx, task.OwnerName, task.ID, codersdk.UpdateTaskInputRequest{
Input: "Updated prompt after cancel",
Expand Down Expand Up @@ -858,7 +868,7 @@ func TestTasks(t *testing.T) {
require.Contains(t, apiErr.Message, "required")
})

t.Run("Running", func(t *testing.T) {
t.Run("WhenInitializing", func(t *testing.T) {
t.Parallel()

client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})
Expand Down Expand Up @@ -887,6 +897,11 @@ func TestTasks(t *testing.T) {
require.Equal(t, codersdk.WorkspaceStatusRunning, workspace.LatestBuild.Status)
require.Equal(t, codersdk.WorkspaceTransitionStart, workspace.LatestBuild.Transition)

// Verify task status is "Active"
task, err = exp.TaskByID(ctx, task.ID)
require.NoError(t, err)
require.Equal(t, codersdk.TaskStatusInitializing, task.Status)

// Attempt to update prompt should fail with 409 Conflict
err = exp.UpdateTaskInput(ctx, task.OwnerName, task.ID, codersdk.UpdateTaskInputRequest{
Input: "Should fail",
Expand Down Expand Up @@ -917,6 +932,43 @@ func TestTasks(t *testing.T) {
require.Equal(t, http.StatusNotFound, apiErr.StatusCode())
})

t.Run("DeletedTask", func(t *testing.T) {
t.Parallel()

client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true})
user := coderdtest.CreateFirstUser(t, client)
ctx := testutil.Context(t, testutil.WaitShort)

template := createAITemplate(t, client, user)

// Create a task with workspace
exp := codersdk.NewExperimentalClient(client)
task, err := exp.CreateTask(ctx, codersdk.Me, codersdk.CreateTaskRequest{
TemplateVersionID: template.ActiveVersionID,
Input: "initial prompt",
})
require.NoError(t, err)
require.True(t, task.WorkspaceID.Valid)

// Wait for workspace to be running
workspace, err := client.Workspace(ctx, task.WorkspaceID.UUID)
require.NoError(t, err)
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID)

// Delete the task
err = exp.DeleteTask(ctx, codersdk.Me, task.ID)
require.NoError(t, err)

// Attempt to update prompt for deleted task
err = exp.UpdateTaskInput(ctx, user.UserID.String(), uuid.New(), codersdk.UpdateTaskInputRequest{
Input: "Should fail",
})
require.Error(t, err)
var apiErr *codersdk.Error
require.ErrorAs(t, err, &apiErr)
require.Equal(t, http.StatusNotFound, apiErr.StatusCode())
})

t.Run("UnauthorizedUser", func(t *testing.T) {
t.Parallel()

Expand Down
Loading