Skip to content

feat: fix build timeline to include entire stage timings #20805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Emyrk merged 18 commits into from
Nov 19, 2025
Merged

feat: fix build timeline to include entire stage timings #20805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
70d1169
feat: include entire stage timings in build timeline
Emyrk Nov 17, 2025
afd6968
add plan stage timing
Emyrk Nov 17, 2025
4d291bc
remove custom init stage boundary timing
Emyrk Nov 17, 2025
023072a
testing frontend ideas
Emyrk Nov 17, 2025
123bda3
add some better FE checks
Emyrk Nov 17, 2025
ecdcd7c
fix stage boundary in stage view
Emyrk Nov 17, 2025
48f9d3a
storybook
Emyrk Nov 17, 2025
f8489b0
make fmt
Emyrk Nov 17, 2025
8408916
correct compile issue
Emyrk Nov 17, 2025
ba09035
remove dead code
Emyrk Nov 17, 2025
e4d5730
lint
Emyrk Nov 17, 2025
0265708
fix test asserts
Emyrk Nov 17, 2025
04208ec
fix story fuzzy matching
Emyrk Nov 17, 2025
c012b45
fix story fuzzy matching
Emyrk Nov 17, 2025
047a8d0
revert flakey storybook fixes
Emyrk Nov 17, 2025
402a21a
chore: rename to total stage duration
Emyrk Nov 18, 2025
80631df
make fmt
Emyrk Nov 18, 2025
d8e078c
pr feedback to update comment
Emyrk Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing frontend ideas
  • Loading branch information
@Emyrk
Emyrk committed Nov 18, 2025
commit 023072ac145d0d72a85fe26b6acd4d34ca42476c
8 changes: 5 additions & 3 deletions site/src/modules/workspaces/WorkspaceTiming/ResourcesChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,11 @@ export const ResourcesChart: FC<ResourcesChartProps> = ({
};

export const isCoderResource = (resource: string) => {
if(resource === "coder_stage") {
return false
}
// coder_stage is a special internal resource that indicates the entire stage timing boundary. It should
// appear differently in the detailed chart.
// if(resource.startsWith("coder_stage_")) {
// return false
// }
return (
resource.startsWith("data.coder") ||
resource.startsWith("module.coder") ||
Expand Down
2 changes: 1 addition & 1 deletion site/src/modules/workspaces/WorkspaceTiming/WorkspaceTimings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export const WorkspaceTimings: FC<WorkspaceTimingsProps> = ({
const visibleResources = stageTimings.filter((t) => {
const isProvisionerTiming = "resource" in t;

if(isProvisionerTiming && t.resource === "coder_stage") {
if(isProvisionerTiming && t.resource.startsWith("coder_stage")) {
return false;
}

Expand Down