-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat!: implement AI Bridge heading to /deployment/observability
#20791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jakehwll, can you share a screenshot of what this will look like? |
ff41882 to
51cb6b9
Compare
matifali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🔥
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only nit-picks
...src/pages/DeploymentSettingsPage/ObservabilitySettingsPage/ObservabilitySettingsPageView.tsx
Show resolved
Hide resolved
...src/pages/DeploymentSettingsPage/ObservabilitySettingsPage/ObservabilitySettingsPageView.tsx
Outdated
Show resolved
Hide resolved
|
@jakehwll make sure we hide the API keys in UI. I see red boxes but they should not be visible. |
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
AI Bridge heading to /deployment/observabilityAI Bridge heading to /deployment/observability
|
@jakehwll I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please ensure description screenshot is updated prior to merge
Caution
In whichever release this lands, we've removed the ability to provide keys via a YAML file (specifically on
openai_key,anthropic_key,bedrock_access_keyand finallybedrock_access_key_secret). This will need to be described in the release notes as to not break peoples AI Bridge integrations upgrading from older versions.This pull-request ensures that we can see the overview of the settings of the
AI Bridgefeature within the/deployment/observabilityroute. This set of options only render when theaibridgefeature flag is enabled.Preview