fix: correctly set touched for autofill dynamic parameters #20769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jaaydenh merged 1 commit into main from jaaydenh/autofill-params-fix

Nov 14, 2025

Contributor

jaaydenh commented Nov 13, 2025

this resolves #20187

This bug was introduced in PR #18894 in CreateWorkspacePageViewExperimental.tsx

This PR made a change so that the entire parameter was used instead of just the parameter name to mark an autofilled parameter as touched.

The fix here is to just use the parameter name.


          fix: correctly set touched for autofill parameters

6b025b3

jaaydenh self-assigned this

jaaydenh requested a review from aslilac

November 13, 2025 20:01

jaaydenh changed the title ~~fix: correctly set touched for autofill parameters~~ fix: correctly set touched for autofill dynamic parameters

aslilac approved these changes

View reviewed changes

Member

aslilac left a comment

whoops!

jaaydenh merged commit 6067aa3 into main

35 checks passed

jaaydenh deleted the jaaydenh/autofill-params-fix branch

November 14, 2025 17:09

github-actions bot locked and limited conversation to collaborators

david-fraley pushed a commit that referenced this pull request


          chore: backport fix #20769 to 2.28 (#20872)

aa5b22c

backport #20769  to 2.28

Fix dynamic parameters for create workspace form when using autofill
params from the url

david-fraley pushed a commit that referenced this pull request


          chore: backport fix #20769 to 2.27 (#20871)

db0f0aa

backport #20769  to 2.27

Fix dynamic parameters for create workspace form when using autofill
params from the url

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet