feat: add duration to the Request Logs details
#20756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duration to the Request Logs detailsduration to the Request Logs details
duration to the Request Logs detailsduration to the Request Logs details
duration to the Request Logs detailsduration to the Request Logs details
deansheather
approved these changes
Nov 13, 2025
Comment on lines
38
to
41
| const duration = | ||
| interception.ended_at && | ||
| new Date(interception.ended_at).getTime() - | ||
| new Date(interception.started_at).getTime(); |
Member
There was a problem hiding this comment.
Could you clamp this to zero if it's somehow negative?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request simply implements a new field within our
Request Logs details view where-in we describe back to the user how long their request took based on theend_date - start_datein a human-like way. Users can hover the value to see thetitle=for the true value.