fix: send all params instead of only touched params #20740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this only on the workspace settings page? I ask because on the workspace created, untouched is important to leave unsent |
Contributor
Author
|
@Emyrk yes, this is only for the workspace settings page. It feels like this is the fundamental difference between the create workspace page and the workspace settings page that was missed originally. |
aslilac
approved these changes
Nov 12, 2025
david-fraley
pushed a commit
that referenced
this pull request
Nov 14, 2025
david-fraley
pushed a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #20257
Ensure all parameters are sent in the web socket request instead of only touched parameters.
Using touched parameters is irrelevant for the workspace parameters page in workspace settings because parameters that appear here have already been chosen by the user during workspace creation. So all parameters should be sent in the web socket request whether have been touched in the form or not.