Skip to content

Conversation

@dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Nov 11, 2025

Currently, when AI Bridge is enabled AND the oauth2 and mcp-server-http experiments are enabled we inject Coder's MCP tools into all intercepted AI Bridge requests.

This PR introduces a config to control this behaviour.

NOTE: this is a backwards-incompatible change; previously these tools would be injected automatically, now this setting will need to be explicitly enabled.

Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we make this opt in i.e. make the default value false. I know it's a breaking change but it's fine given not every client needs the coder MCP tools.

We will plan on a more granular per user/template config for MCP servers/tools for future roadmap.

@dannykopping
Copy link
Contributor Author

I suggest we make this opt in i.e. make the default value false. I know it's a breaking change but it's fine given not every client needs the coder MCP tools.

OK. We will need to call it out in the next release's notes in that case.

@dannykopping dannykopping changed the title chore: allow coder MCP tools to not be injected !chore: allow coder MCP tools to not be injected Nov 11, 2025
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping changed the title !chore: allow coder MCP tools to not be injected chore!: allow coder MCP tools to not be injected Nov 11, 2025
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping marked this pull request as ready for review November 11, 2025 13:00
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Nov 11, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flow looks good to me. Thanks.

dannykopping and others added 2 commits November 11, 2025 21:34
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping merged commit 04f809f into main Nov 12, 2025
35 checks passed
@dannykopping dannykopping deleted the dk/inject-coder-mcp branch November 12, 2025 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
@matifali
Copy link
Member

Can we update https://coder.com/docs/ai-coder/ai-bridge/mcp with this change? Thanks

@dannykopping
Copy link
Contributor Author

Can we update https://coder.com/docs/ai-coder/ai-bridge/mcp with this change? Thanks

Good call, #20735

@matifali matifali linked an issue Nov 13, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop auto injecting Coder MCP tools

4 participants