Skip to content

fix: set codersdk.Task current_state during task initialization #20692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssncferreira merged 17 commits into from
Nov 17, 2025
+319 −23
Merged

fix: set codersdk.Task current_state during task initialization #20692

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6d099cb
fix: set codersdk.Task current_state during task initialization
ssncferreira Nov 10, 2025
7191e4b
fix: TestTasks/Get test
ssncferreira Nov 11, 2025
eefbc3f
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 11, 2025
d391626
test: add InitializingAgentState tests
ssncferreira Nov 11, 2025
c6c5c7f
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 11, 2025
cf9a97e
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 12, 2025
306296a
fix: minor fix in TestTasks test
ssncferreira Nov 12, 2025
f07e3d8
chore: address comments
ssncferreira Nov 12, 2025
c7a0c14
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 12, 2025
b1cb7fe
test: create internal test file for unit test
ssncferreira Nov 14, 2025
0ae69ba
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 14, 2025
23bd215
chore: minor fixes
ssncferreira Nov 14, 2025
a069cbf
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 17, 2025
9e9b80f
chore: use agent lifecycle and app health from dbTask
ssncferreira Nov 17, 2025
979e370
chore: address comments
ssncferreira Nov 17, 2025
677339d
chore: address comments
ssncferreira Nov 17, 2025
6582f80
Merge remote-tracking branch 'origin/main' into ssncferreira/fix-task…
ssncferreira Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: address comments
  • Loading branch information
@ssncferreira
ssncferreira committed Nov 17, 2025
commit 677339d94352f0357db53a58719519e28507d601
2 changes: 2 additions & 0 deletions coderd/aitasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ func deriveTaskCurrentState(
message = "Initializing workspace applications"
}
default:
// In case the workspace agent is not initializing,
// the overall task status should be updated accordingly
message = "Initializing workspace agent"
Copy link
Member

@mafredri mafredri Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should never happen, but the fallback is fine, should we log something if this happens?

Copy link
Contributor Author

@ssncferreira ssncferreira Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should never happen, similarly to the "Initializing workspace applications" path. I think adding a comment here is enough for now. Addressed in 677339d

}
Copy link
Member

@mafredri mafredri Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take into account the coder app status as well?

Copy link
Contributor Author

@ssncferreira ssncferreira Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean LatestAppStatus? I thought about adding different messages based on the app status state, for example, if LatestAppStatus.State == idle, the message could be "Agent is idle", or for completed/failed states, we could provide more detailed information to users. Or were you thinking of something else?

Copy link
Member

@mafredri mafredri Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about WorkspaceAppHealth, specifically WorkspaceAppHealthInitializing. If disabled we can ignore it.

I'm not sure if we need to enrich LatestAppStatus if there already exists an entry 🤔. I imagine users could want to tweak that via having the agent give some context via the mcp report tool.

Copy link
Contributor Author

@ssncferreira ssncferreira Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about WorkspaceAppHealth, specifically WorkspaceAppHealthInitializing. If disabled we can ignore it.

Ah, I see. So this would be the case where the agent is ready but the app is still initializing, correct? Do you think it makes sense to get into that level of detail? We have different possible AppHealth statuses:

WorkspaceAppHealthDisabled     WorkspaceAppHealth = "disabled"
WorkspaceAppHealthInitializing WorkspaceAppHealth = "initializing"
WorkspaceAppHealthHealthy      WorkspaceAppHealth = "healthy"
WorkspaceAppHealthUnhealthy    WorkspaceAppHealth = "unhealthy"

I'm guessing only the initializing here would make sense, because the others would probably affect the overall task status, correct?

Copy link
Member

@mafredri mafredri Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would be the case where the agent is ready but the app is still initializing, correct?

Yep! 👍🏻

Do you think it makes sense to get into that level of detail?

It would better reflect how we determine the tasks status in the tasks_with_status view.

I'm guessing only the initializing here would make sense, because the others would probably affect the overall task status, correct?

Correct. 👍🏻

We could consider unhealthy as well, but that would open a can of worms I'd prefer to avoid for now (messages for agent health, workspace build failure, etc).

Copy link
Contributor Author

@ssncferreira ssncferreira Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in b1cb7fe

}
Expand Down
Loading