refactor!: remove TaskAppID from codersdk.WorkspaceBuild #20583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48f0148 to
25cba70
Compare
We can instead use the new data model for this, there is no reason to have it stored inside the workspace build. `TaskAppID` has not _yet_ been shipped into a release. This would need cherry-picking if we wanted to go ahead with it. If we don't want to cherry-pick, we should instead mark the TaskAppID as deprecated. This isn't ideal as it hasn't even been released yet.
25cba70 to
7a97ebe
Compare
mafredri
approved these changes
Oct 30, 2025
| TemplateVersionPresetID *uuid.UUID `json:"template_version_preset_id" format:"uuid"` | ||
| HasAITask *bool `json:"has_ai_task,omitempty"` | ||
| // Deprecated: This field has been replaced with `TaskAppID` | ||
| // Deprecated: This field has been replaced with `Task.WorkspaceAppID` |
johnstcn
approved these changes
Oct 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can instead use the new data model for this, there is no reason to have it stored inside the workspace build.
TaskAppIDhas not yet been shipped into a release. This would need cherry-picking if we wanted to go ahead with it.