Skip to content

chore: add experiment toggle for terraform workspace caching #20559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Emyrk merged 3 commits into from
Nov 12, 2025
Merged

chore: add experiment toggle for terraform workspace caching #20559

Emyrk merged 3 commits into from
Nov 12, 2025

Conversation

@Emyrk
Copy link
Member

@Emyrk Emyrk commented Oct 29, 2025 •
edited
Loading

Experiments passed to provisioners to determine behavior. This adds --experiments flag to provisioner daemons. Prior to this, provisioners had no method to turn on/off experiments.

@Emyrk Graphite App
Copy link
Member Author

Emyrk commented Oct 29, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Emyrk Emyrk mentioned this pull request Oct 29, 2025
Merged
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from 1af6b7c to 41a5a63 Compare October 29, 2025 19:50
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from c3b32a2 to fa61201 Compare October 29, 2025 20:00
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from a8d9cbd to cbc9d5d Compare October 29, 2025 20:00
@Emyrk Emyrk mentioned this pull request Oct 29, 2025
Merged
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from cbc9d5d to e5c2b88 Compare October 30, 2025 14:59
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from fa61201 to d36ffea Compare October 30, 2025 14:59
@Emyrk Emyrk mentioned this pull request Oct 30, 2025
Merged
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from e5c2b88 to 87b5981 Compare October 30, 2025 16:12
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch 2 times, most recently from 5ea5ce3 to 40618ae Compare October 30, 2025 16:25
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from 27759a1 to 621163e Compare October 30, 2025 16:26
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from c63a20b to f3493e0 Compare October 30, 2025 16:28
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from 4f4daa1 to fb8dd3a Compare October 30, 2025 16:49
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from f3493e0 to 60e940f Compare October 30, 2025 16:49
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from 5b3f9f8 to 5923703 Compare October 30, 2025 17:02
@Emyrk Emyrk mentioned this pull request Oct 31, 2025
Merged
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 8, 2025
Emyrk
Emyrk commented Nov 10, 2025
View reviewed changes
codersdk/deployment.go Outdated
Comment on lines 3638 to 3650
// ExperimentTerraformWorkspace is named after the "Terraform Workspaces" feature, not to be confused with Coder Workspaces.
ExperimentTerraformWorkspace Experiment = "terraform-workspaces" // Enables reuse of existing terraform directory for builds
Copy link
Member Author

@Emyrk Emyrk Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the name of the feature being used in Terraform

Copy link
Contributor

@dannykopping dannykopping Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may be, but we're inviting confusion. When we document this feature we can link to the actual feature docs, but I think we should give it our own logical name.

Copy link
Member Author

@Emyrk Emyrk Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename it internally 👍

@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from f798c44 to 67115b1 Compare November 10, 2025 15:30
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from 2f45b69 to 86c520b Compare November 10, 2025 15:32
@Emyrk Emyrk marked this pull request as ready for review November 10, 2025 15:32
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from 86c520b to 5aea76c Compare November 10, 2025 16:13
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from 08880d3 to b882573 Compare November 10, 2025 16:17
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from 0b9bfd3 to dc088ac Compare November 12, 2025 14:52
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from 88a203b to 6e163e9 Compare November 12, 2025 14:52
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from dc088ac to 9ef3669 Compare November 12, 2025 15:01
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch 2 times, most recently from 876150c to 8ef24ef Compare November 12, 2025 15:24
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from 8ef24ef to 74bee78 Compare November 12, 2025 15:25
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 3 times, most recently from eae338b to dfeb82c Compare November 12, 2025 15:55
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from 74bee78 to 477877d Compare November 12, 2025 15:55
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 3 times, most recently from 4005dbf to fa93b50 Compare November 12, 2025 16:53
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from 41faf32 to a5bf278 Compare November 12, 2025 17:54
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from fa93b50 to 17ad382 Compare November 12, 2025 17:54
@Emyrk Emyrk force-pushed the stevenmasley/provisioner_tmpl_ver_metadata branch from a5bf278 to b074539 Compare November 12, 2025 18:17
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from 388275e to 71a5ca9 Compare November 12, 2025 18:25
Base automatically changed from stevenmasley/provisioner_tmpl_ver_metadata to main November 12, 2025 18:46
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch 2 times, most recently from a51ae86 to a6914e7 Compare November 12, 2025 19:59
@Emyrk Emyrk force-pushed the stevenmasley/cache_init_exp branch from a6914e7 to 93aca5b Compare November 12, 2025 20:01
@Emyrk Emyrk merged commit 04727c0 into main Nov 12, 2025
31 checks passed
@Emyrk Emyrk deleted the stevenmasley/cache_init_exp branch November 12, 2025 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dannykopping dannykopping dannykopping approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@Emyrk Emyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk @dannykopping