chore: append template metadata to protobuf config #20558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
c3b32a2 to
fa61201
Compare
fa61201 to
d36ffea
Compare
27dc8e3 to
1938cf1
Compare
b7321d6 to
52064b7
Compare
f3493e0 to
60e940f
Compare
52064b7 to
bbf6058
Compare
f798c44 to
67115b1
Compare
johnstcn
approved these changes
Nov 10, 2025
Member
johnstcn
left a comment
There was a problem hiding this comment.
Protobuf fields LGTM 👍 Some other comments below but nothing blocking.
Comment on lines
60
to
67
| // | ||
| // API v1.12: | ||
| // - Added new field `template_version_id` to `provisioner.Metadata` | ||
| // - Added new field `terraform_workspace_reuse` to `provisioner.Job.WorkspaceBuild` | ||
| // - Added fields `template_version_id`, `template_id`, and `terraform_workspace_reuse` to `provisioner.Config` | ||
| const ( | ||
| CurrentMajor = 1 | ||
| CurrentMinor = 11 | ||
| CurrentMinor = 12 |
08880d3 to
b882573
Compare
bbf6058 to
fc6bb0a
Compare
195f4e0 to
88a203b
Compare
dannykopping
approved these changes
Nov 11, 2025
| } | ||
|
|
||
| type TemplateVersionImportJob struct { | ||
| // TemplateID is not guaranteed to be set. Template versions can be created |
Contributor
There was a problem hiding this comment.
Template versions can be created without being associated with a template.
Can you elaborate on that?
Do we create an initial template version first then associate it with a template?
Member
There was a problem hiding this comment.
Do we create an initial template version first then associate it with a template?
Correct, see cli/templatepush.go for illustration.
Member
Author
There was a problem hiding this comment.
Yea, it's been a thorn in my side for a long time that the first template push is an orphaned version 😢
Member
Author
|
TODO: Mark these fields as optional and prefix by |
fc6bb0a to
b88ee78
Compare
6e163e9 to
876150c
Compare
b88ee78 to
e8bf6de
Compare
e8bf6de to
7c8deaf
Compare
876150c to
8ef24ef
Compare
f0bf9eb to
41faf32
Compare
41faf32 to
a5bf278
Compare
a5bf278 to
b074539
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some extra meta data sent to provisioners. Also adds a field
terraform_workspace_reuseto tell the provisioner whether or not to use the caching experiment.For terraform directory reuse, the
template-version-idandtemplate-idis required.These values are used to determine the terraform working directory, and also when to clean up "old" versions. The actual cache cleanup might be changed by GA. This is still an experiment.