fix: rename total to count in AIBridgeListInterceptionsResponse
#20410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| type AIBridgeListInterceptionsResponse struct { | ||
| Total int64 `json:"total"` | ||
| Count int64 `json:"count"` |
Member
There was a problem hiding this comment.
It'll need to be changed in test files too. I suggest undoing your changes and then doing an automated rename refactor operation in vscode (which should change it everywhere). Then re-run make gen
deansheather
approved these changes
Oct 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the great work in #20393, we’ve successfully introduced offset-based pagination for this endpoint. However, the frontend expects a
countfield in the response rather thantotal. This PR updates the response payload to rename the returned key tocountfor consistency with frontend expectations and existing API patterns.This is necessary to unblock the work in #20331