chore: migrate MUI icons to lucide-react #20193
Conversation
|
Just reviewed all the stories. I really like a lot of the changes, but some icons got way too big, and I think a couple of UI elements could be tweaked I accepted all the stories that I had zero issue with. The only rejected stories are the ones that I think absolutely need to change. Everything else was checked, and while I was unsure about the changes, I think I could be talked into accepting them pretty easily |
|
@Parkreiner I reviewed all your comments and made the requested changes. Thanks for the feedback — it was super helpful! 🙏 |
| /> | ||
| )} | ||
| <span | ||
| className={`${info.hasDiff && "text-content-warning"}`} |
There was a problem hiding this comment.
Oh, this looks like a bug. If info.hasDiff evaluates to false, we'll short-circuit and not evaluate the string. But then the expression will still be false, and we'll put that in the template literal, so then we'll have class="false" in the HTML
Feel like cn is probably the easiest way to fix this
cfacd1c to
818a1bb
Compare
No description provided.