test: add tests for updating workspace acl #19240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Aug 7, 2025
Comment on lines
+4839
to
+4846
| ctx := testutil.Context(t, testutil.WaitMedium) | ||
| err := client.UpdateWorkspaceACL(ctx, ws.ID, codersdk.UpdateWorkspaceACL{ | ||
| UserRoles: map[string]codersdk.WorkspaceRole{ | ||
| friend.ID.String(): codersdk.WorkspaceRoleAdmin, | ||
| }, | ||
| }) | ||
| require.NoError(t, err) | ||
| }) |
There was a problem hiding this comment.
Should you test the friend can access the workspace with some friendClient call?
There was a problem hiding this comment.
I wanna go a step farther and do that as part of some e2e tests in a coming pr
Comment on lines
+3559
to
+3567
| err := client.UpdateWorkspaceACL(ctx, ws.ID, codersdk.UpdateWorkspaceACL{ | ||
| UserRoles: map[string]codersdk.WorkspaceRole{ | ||
| friend.ID.String(): codersdk.WorkspaceRoleAdmin, | ||
| }, | ||
| GroupRoles: map[string]codersdk.WorkspaceRole{ | ||
| group.ID.String(): codersdk.WorkspaceRoleAdmin, | ||
| }, | ||
| }) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Same as user comment. Maybe try to access the workspace via the new acl. And not use the UserRoles
There was a problem hiding this comment.
same here. I'll also do an e2e test for making sure multiple users in a group can access a shared workspace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing tests for the
/acl [patch]route