Skip to content

test: fix timeout on TestServer_X11_EvictionLRU #19217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Aug 7, 2025

fixes coder/internal#878

On my dev system it takes 900ms, but looking at timestamps in CI it took 25 seconds. Bumping timeout to 60s.

Also fixes the segfault.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested a review from mafredri August 7, 2025 10:09
@spikecurtis spikecurtis marked this pull request as ready for review August 7, 2025 10:09
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange that the in process networking runs for 25s in CI, perhaps our parallelism is too high. But change is fine either way 👍🏻

@spikecurtis
Copy link
Contributor Author

Yeah, kind of wild to see 25x slower on the CI runner. I think CI has gotten notably more congested, possibly due to using a real postgreSQL...

@spikecurtis spikecurtis merged commit 6ba5521 into main Aug 7, 2025
38 checks passed
@spikecurtis spikecurtis deleted the spike/internal-878 branch August 7, 2025 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestServer_X11_EvictionLRU
2 participants