-
Notifications
You must be signed in to change notification settings - Fork 956
fix(site): add tests for createMockWebSocket
#19172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a87e93e
1c48afc
5eff4df
c2d07fb
21c9eb8
1834c59
6ee9afc
c95aa4b
cb42aa7
b63ff10
dab74d7
c17ee61
9b155b1
5f9032d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,186 @@ | ||
import { createMockWebSocket } from "./websockets"; | ||
|
||
describe(createMockWebSocket.name, () => { | ||
it("Throws if URL does not have ws:// or wss:// protocols", () => { | ||
const urls: readonly string[] = [ | ||
"http://www.dog.ceo/roll-over", | ||
"https://www.dog.ceo/roll-over", | ||
]; | ||
for (const url of urls) { | ||
expect(() => { | ||
void createMockWebSocket(url); | ||
}).toThrow("URL must start with ws:// or wss://"); | ||
} | ||
}); | ||
|
||
it("Sends events from server to socket", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/shake"); | ||
|
||
const onOpen = jest.fn(); | ||
const onError = jest.fn(); | ||
const onMessage = jest.fn(); | ||
const onClose = jest.fn(); | ||
|
||
socket.addEventListener("open", onOpen); | ||
socket.addEventListener("error", onError); | ||
socket.addEventListener("message", onMessage); | ||
socket.addEventListener("close", onClose); | ||
|
||
const openEvent = new Event("open"); | ||
const errorEvent = new Event("error"); | ||
const messageEvent = new MessageEvent<string>("message"); | ||
const closeEvent = new CloseEvent("close"); | ||
|
||
server.publishOpen(openEvent); | ||
server.publishError(errorEvent); | ||
server.publishMessage(messageEvent); | ||
server.publishClose(closeEvent); | ||
|
||
expect(onOpen).toHaveBeenCalledTimes(1); | ||
expect(onOpen).toHaveBeenCalledWith(openEvent); | ||
|
||
expect(onError).toHaveBeenCalledTimes(1); | ||
expect(onError).toHaveBeenCalledWith(errorEvent); | ||
|
||
expect(onMessage).toHaveBeenCalledTimes(1); | ||
expect(onMessage).toHaveBeenCalledWith(messageEvent); | ||
|
||
expect(onClose).toHaveBeenCalledTimes(1); | ||
expect(onClose).toHaveBeenCalledWith(closeEvent); | ||
Comment on lines
+48
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this test makes me feel like I'm looking at a freshly ironed shirt. super nice! |
||
}); | ||
|
||
it("Sends JSON data to the socket for message events", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/wag"); | ||
const onMessage = jest.fn(); | ||
|
||
// Could type this as a special JSON type, but unknown is good enough, | ||
// since any invalid values will throw in the test case | ||
const jsonData: readonly unknown[] = [ | ||
"blah", | ||
42, | ||
true, | ||
false, | ||
null, | ||
{}, | ||
[], | ||
[{ value: "blah" }, { value: "guh" }, { value: "huh" }], | ||
{ | ||
name: "Hershel Layton", | ||
age: 40, | ||
profession: "Puzzle Solver", | ||
sadBackstory: true, | ||
greatVideoGames: true, | ||
}, | ||
]; | ||
for (const jd of jsonData) { | ||
socket.addEventListener("message", onMessage); | ||
server.publishMessage( | ||
new MessageEvent("message", { data: JSON.stringify(jd) }), | ||
); | ||
|
||
expect(onMessage).toHaveBeenCalledTimes(1); | ||
expect(onMessage).toHaveBeenCalledWith( | ||
new MessageEvent("message", { data: JSON.stringify(jd) }), | ||
); | ||
|
||
socket.removeEventListener("message", onMessage); | ||
onMessage.mockClear(); | ||
} | ||
}); | ||
|
||
it("Only registers each socket event handler once", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/borf"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. borf!!! |
||
|
||
const onOpen = jest.fn(); | ||
const onError = jest.fn(); | ||
const onMessage = jest.fn(); | ||
const onClose = jest.fn(); | ||
|
||
// Do it once | ||
socket.addEventListener("open", onOpen); | ||
socket.addEventListener("error", onError); | ||
socket.addEventListener("message", onMessage); | ||
socket.addEventListener("close", onClose); | ||
|
||
// Do it again with the exact same functions | ||
socket.addEventListener("open", onOpen); | ||
socket.addEventListener("error", onError); | ||
socket.addEventListener("message", onMessage); | ||
socket.addEventListener("close", onClose); | ||
|
||
server.publishOpen(new Event("open")); | ||
server.publishError(new Event("error")); | ||
server.publishMessage(new MessageEvent<string>("message")); | ||
server.publishClose(new CloseEvent("close")); | ||
|
||
expect(onOpen).toHaveBeenCalledTimes(1); | ||
expect(onError).toHaveBeenCalledTimes(1); | ||
expect(onMessage).toHaveBeenCalledTimes(1); | ||
expect(onClose).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it("Lets a socket unsubscribe to event types", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/zoomies"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. zoomies!!! |
||
|
||
const onOpen = jest.fn(); | ||
const onError = jest.fn(); | ||
const onMessage = jest.fn(); | ||
const onClose = jest.fn(); | ||
|
||
socket.addEventListener("open", onOpen); | ||
socket.addEventListener("error", onError); | ||
socket.addEventListener("message", onMessage); | ||
socket.addEventListener("close", onClose); | ||
|
||
socket.removeEventListener("open", onOpen); | ||
socket.removeEventListener("error", onError); | ||
socket.removeEventListener("message", onMessage); | ||
socket.removeEventListener("close", onClose); | ||
|
||
server.publishOpen(new Event("open")); | ||
server.publishError(new Event("error")); | ||
server.publishMessage(new MessageEvent<string>("message")); | ||
server.publishClose(new CloseEvent("close")); | ||
|
||
expect(onOpen).not.toHaveBeenCalled(); | ||
expect(onError).not.toHaveBeenCalled(); | ||
expect(onMessage).not.toHaveBeenCalled(); | ||
expect(onClose).not.toHaveBeenCalled(); | ||
}); | ||
|
||
it("Renders socket inert after being closed", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/woof"); | ||
expect(server.isConnectionOpen).toBe(true); | ||
|
||
const onMessage = jest.fn(); | ||
socket.addEventListener("message", onMessage); | ||
|
||
socket.close(); | ||
expect(server.isConnectionOpen).toBe(false); | ||
|
||
server.publishMessage(new MessageEvent<string>("message")); | ||
expect(onMessage).not.toHaveBeenCalled(); | ||
}); | ||
|
||
it("Tracks arguments sent by the mock socket", () => { | ||
const [socket, server] = createMockWebSocket("wss://www.dog.ceo/wan-wan"); | ||
const data = JSON.stringify({ | ||
famousDogs: [ | ||
"snoopy", | ||
"clifford", | ||
"lassie", | ||
"beethoven", | ||
"courage the cowardly dog", | ||
], | ||
}); | ||
|
||
socket.send(data); | ||
expect(server.clientSentData).toHaveLength(1); | ||
expect(server.clientSentData).toEqual([data]); | ||
|
||
socket.close(); | ||
socket.send(data); | ||
expect(server.clientSentData).toHaveLength(1); | ||
expect(server.clientSentData).toEqual([data]); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
import type { WebSocketEventType } from "utils/OneWayWebSocket"; | ||
|
||
type SocketSendData = Parameters<WebSocket["send"]>[0]; | ||
|
||
export type MockWebSocketServer = Readonly<{ | ||
publishMessage: (event: MessageEvent<string>) => void; | ||
publishError: (event: Event) => void; | ||
publishClose: (event: CloseEvent) => void; | ||
publishOpen: (event: Event) => void; | ||
|
||
readonly isConnectionOpen: boolean; | ||
readonly clientSentData: readonly SocketSendData[]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was one part I was a little torn on, and I'd be open to alternative ways to track data sent from the mock socket to the mock server It feels like the "boy scout" way of doing this would be with subscription callbacks, but since we'd likely just be checking the contents for a single isolated test case, that'd add more boilerplate to all test cases when we really just care about what data got sent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. totally seems good enough to me
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. am I missing something or are these actually super mutable? I would expect that the connection closes eventually and data sent to the client gets added to I don't mind using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'm understanding what you're asking about, but if this doesn't answer your question at all, let me know: So TypeScript's confusing in the sense that the The getter method version is actually closer to true readonly, because even at runtime, there's no way to modify the value. Basically, I intended for the mock socket and server to have a single shared boolean property, but I didn't want to have the server to have the ability to set it manually and break the "connection" with the socket. I had this defined as a method at first, but the getter method approach seemed more ergonomic |
||
}>; | ||
|
||
type CallbackStore = { | ||
[K in keyof WebSocketEventMap]: Set<(event: WebSocketEventMap[K]) => void>; | ||
}; | ||
|
||
type MockWebSocket = Omit<WebSocket, "send"> & { | ||
/** | ||
* A version of the WebSocket `send` method that has been pre-wrapped inside | ||
* a Jest mock. | ||
* | ||
* The Jest mock functionality should be used at a minimum. Basically: | ||
* 1. If you want to check that the mock socket sent something to the mock | ||
* server: call the `send` method as a function, and then check the | ||
* `clientSentData` on `MockWebSocketServer` to see what data got | ||
* received. | ||
* 2. If you need to make sure that the client-side `send` method got called | ||
* at all: you can use the Jest mock functionality, but you should | ||
* probably also be checking `clientSentData` still and making additional | ||
* assertions with it. | ||
* | ||
* Generally, tests should center around whether socket-to-server | ||
* communication was successful, not whether the client-side method was | ||
* called. | ||
*/ | ||
send: jest.Mock<void, [SocketSendData], unknown>; | ||
}; | ||
|
||
export function createMockWebSocket( | ||
url: string, | ||
protocol?: string | string[] | undefined, | ||
): readonly [MockWebSocket, MockWebSocketServer] { | ||
if (!url.startsWith("ws://") && !url.startsWith("wss://")) { | ||
throw new Error("URL must start with ws:// or wss://"); | ||
} | ||
|
||
const activeProtocol = Array.isArray(protocol) | ||
? protocol.join(" ") | ||
: (protocol ?? ""); | ||
|
||
let isOpen = true; | ||
const store: CallbackStore = { | ||
message: new Set(), | ||
error: new Set(), | ||
close: new Set(), | ||
open: new Set(), | ||
}; | ||
|
||
const sentData: SocketSendData[] = []; | ||
|
||
const mockSocket: MockWebSocket = { | ||
CONNECTING: 0, | ||
OPEN: 1, | ||
CLOSING: 2, | ||
CLOSED: 3, | ||
|
||
url, | ||
protocol: activeProtocol, | ||
readyState: 1, | ||
binaryType: "blob", | ||
bufferedAmount: 0, | ||
extensions: "", | ||
onclose: null, | ||
onerror: null, | ||
onmessage: null, | ||
onopen: null, | ||
dispatchEvent: jest.fn(), | ||
|
||
send: jest.fn((data) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
sentData.push(data); | ||
}), | ||
|
||
addEventListener: <E extends WebSocketEventType>( | ||
eventType: E, | ||
callback: (event: WebSocketEventMap[E]) => void, | ||
) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
const subscribers = store[eventType]; | ||
subscribers.add(callback); | ||
}, | ||
|
||
removeEventListener: <E extends WebSocketEventType>( | ||
eventType: E, | ||
callback: (event: WebSocketEventMap[E]) => void, | ||
) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
const subscribers = store[eventType]; | ||
subscribers.delete(callback); | ||
}, | ||
|
||
close: () => { | ||
isOpen = false; | ||
}, | ||
}; | ||
|
||
const publisher: MockWebSocketServer = { | ||
get isConnectionOpen() { | ||
return isOpen; | ||
}, | ||
|
||
get clientSentData() { | ||
return [...sentData]; | ||
}, | ||
Comment on lines
+120
to
+122
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cheeky little copy for immutability, nice. |
||
|
||
publishOpen: (event) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
for (const sub of store.open) { | ||
sub(event); | ||
} | ||
}, | ||
|
||
publishError: (event) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
for (const sub of store.error) { | ||
sub(event); | ||
} | ||
}, | ||
|
||
publishMessage: (event) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
for (const sub of store.message) { | ||
sub(event); | ||
} | ||
}, | ||
|
||
publishClose: (event) => { | ||
if (!isOpen) { | ||
return; | ||
} | ||
for (const sub of store.close) { | ||
sub(event); | ||
} | ||
}, | ||
}; | ||
|
||
return [mockSocket, publisher] as const; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dog.ceo!!!