chore(coderd/provisionerdserver): remove dangerous usage of dbtestutil.DisableForeignKeysAndTriggers #19122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

johnstcn merged 1 commit into main from cj/chore/provisionerdserver-no-disable-foreign-key-checks

Aug 4, 2025

+284 −183

Member

johnstcn commented Aug 2, 2025

May have caught #18776


          chore(coderd/provisionerdserver): remove dangerous usage of dbtestuti…

84b852b

…l.DisableForeignKeysAndTriggers

johnstcn self-assigned this

johnstcn requested review from dannykopping, spikecurtis and Emyrk

August 2, 2025 16:29

spikecurtis approved these changes

View reviewed changes

Emyrk approved these changes

View reviewed changes

Member

Emyrk left a comment

Nice! Ideally we remove this everywhere incrementally. Maybe we should add a linter to catch new additions?

johnstcn merged commit b0ba798 into main

50 of 54 checks passed

johnstcn deleted the cj/chore/provisionerdserver-no-disable-foreign-key-checks branch

August 4, 2025 20:51

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet