chore(site): add preset combobox to dynamic parameters page #19100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
approved these changes
Jul 30, 2025
aslilac
reviewed
Jul 31, 2025
Comment on lines
+586
to
+590
| // "undefined" string is equivalent to using None option | ||
| // Combobox requires a value in order to correctly highlight the None option | ||
| presetOptions[index].value === "undefined" | ||
| ? undefined | ||
| : presetOptions[index].value, |
There was a problem hiding this comment.
sorry to keep bringing up merged pull requests, but couldn't value just be ""? then it wouldn't need this special handling, as undefined gets deserialized the same as "" by the backend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
CreateWorkspacePageViewExperimentalpage to use theComboboxReact component for preset selection. This aligns it with the implementation used in the standardCreateWorkspacePageView, ensuring consistency in UI behavior and component usage across both pages.Related to
CreateWorkspacePageViewchanges: #19063