chore: remove soft isolation configurability #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

deansheather merged 2 commits into main from dean/vpn-remove-soft-isolation-config

Jul 29, 2025

Member

deansheather commented Jul 29, 2025

Undoes a lot of the changes in 5319d47

Keeps the netns.SetCoderSoftIsolation() call, but always sets it to true when using a TUN device.


          chore: remove soft isolation configurability

76c663c

deansheather requested a review from ethanndickson

July 29, 2025 08:06

deansheather requested review from spikecurtis and johnstcn as code owners

July 29, 2025 08:06

github-actions bot assigned deansheather

ethanndickson previously approved these changes

View reviewed changes

ethanndickson dismissed their stale review

July 29, 2025 08:08

too hasty


          version undo

6a52ebe

johnstcn reviewed

View reviewed changes

Member

johnstcn left a comment

VPN proto changes look OK to me as the 1.3 changes were only added a few days ago (see 5319d47) and have not yet been released. I don't have sufficient context for the rest of the changes.

spikecurtis approved these changes

View reviewed changes

deansheather merged commit bf78966 into main

69 of 73 checks passed

deansheather deleted the dean/vpn-remove-soft-isolation-config branch

July 29, 2025 12:30

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet