-
Notifications
You must be signed in to change notification settings - Fork 955
feat: add tmux and gemini icons #19031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Please also run make gen
/cherry-pick release/2.24 |
Can you run make gen, and get these failing CI's resolved so we can merge this for the gemini and tmux icons? |
@DevelopmentCats Is there any script to install all the dependencies ? I tried running |
@DevelopmentCats can you approve the ci tests |
Error:
|
Related PRs: #246 #229