Skip to content

feat: make dynamic parameters opt-in by default for new templates #19006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jul 29, 2025
Merged

feat: make dynamic parameters opt-in by default for new templates #19006

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
532218e
feat: make dynamic parameters opt-in by default for new templates
jaaydenh Jul 22, 2025
2ec5806
fix: format
jaaydenh Jul 22, 2025
b933efe
fix: fix stories
jaaydenh Jul 22, 2025
7144f4f
chore: update warning content
jaaydenh Jul 24, 2025
170c5c6
chore: cleanup
jaaydenh Jul 28, 2025
9bbd2b2
flip golden default value
Emyrk Jul 28, 2025
f25a9f8
chore: echo provisioner reponses to include terraform to match
Emyrk Jul 28, 2025
b10945c
fixup! chore: echo provisioner reponses to include terraform to match
Emyrk Jul 28, 2025
67dc627
fixup! fixup! chore: echo provisioner reponses to include terraform t…
Emyrk Jul 28, 2025
9eeb11b
fix: use classic parameter flow for MockWorkspace
jaaydenh Jul 28, 2025
7aa393c
sane defaultS
Emyrk Jul 28, 2025
238df67
sane defaultS
Emyrk Jul 28, 2025
ee116fb
fixup! sane defaultS
Emyrk Jul 28, 2025
d6a2262
fixup! fixup! sane defaultS
Emyrk Jul 28, 2025
cf8deb0
restart and ephemeral parameters resolved
Emyrk Jul 28, 2025
fc7b5d7
fixup! restart and ephemeral parameters resolved
Emyrk Jul 28, 2025
adce52e
add todo to fix this later
Emyrk Jul 28, 2025
a2358bf
fix: fix storybook tests
jaaydenh Jul 28, 2025
273411a
add todo to fix this later
Emyrk Jul 28, 2025
0501cff
add todo to fix this later
Emyrk Jul 28, 2025
b7064c0
default orphaned template versions to dynamic params
Emyrk Jul 28, 2025
fdbf0eb
add migration to make data schema consistent
Emyrk Jul 28, 2025
326d2bf
fixup! add migration to make data schema consistent
Emyrk Jul 28, 2025
83e643d
make fmt
Emyrk Jul 28, 2025
ccb76a4
fixup tag tests
Emyrk Jul 28, 2025
c4f4fe5
parameters require names
Emyrk Jul 28, 2025
95f53fd
fix(e2e): disable dynamic parameters for updateWorkspace tests
blink-so[bot] Jul 28, 2025
9ba0b67
fix: use classic parameters for workspace tests
jaaydenh Jul 28, 2025
5cd3e0b
fix: fix e2e tests
jaaydenh Jul 28, 2025
53b9ec6
fix: fix format
jaaydenh Jul 28, 2025
8fb0043
fix form type
Emyrk Jul 28, 2025
f88a934
fix test race
Emyrk Jul 29, 2025
1aad58e
test fixes
Emyrk Jul 29, 2025
5f1320c
formatting
Emyrk Jul 29, 2025
9c4aa40
remove unused file
Emyrk Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sane defaultS
  • Loading branch information
@Emyrk
Emyrk committed Jul 28, 2025
commit 7aa393cdb6cebff37a62c9ff788e74b88faa5fc9
6 changes: 3 additions & 3 deletions coderd/workspaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,9 @@ func TestWorkspace(t *testing.T) {

// Test Utility variables
templateVersionParameters := []*proto.RichParameter{
{Name: "param1", Type: "string", Required: false},
{Name: "param2", Type: "string", Required: false},
{Name: "param3", Type: "string", Required: false},
{Name: "param1", Type: "string", Required: false, DefaultValue: "default1"},
{Name: "param2", Type: "string", Required: false, DefaultValue: "default2"},
{Name: "param3", Type: "string", Required: false, DefaultValue: "default3"},
}
presetParameters := []*proto.PresetParameter{
{Name: "param1", Value: "value1"},
Expand Down
Loading