Skip to content

fix: use resource_id directly for coder_metadata association #18300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: use resource_id directly for coder_metadata association #18300

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9d60f47
fix: respect resource_id for coder_metadata
sreya Jun 10, 2025
1232eaa
cache id
sreya Jun 10, 2025
6182af4
update tests
sreya Jun 12, 2025
49a3a2b
fix tests
sreya Jun 12, 2025
f1dabf7
make fmt
sreya Jun 12, 2025
cfb02c7
remove comment
sreya Jun 12, 2025
3d92225
handle duplicate TF IDs
sreya Jun 12, 2025
a2afc35
undo deleted file
sreya Jun 12, 2025
7e0c0a2
ci: fix linter errors
ThomasK33 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@sreya @ThomasK33
sreya authored and ThomasK33 committed Aug 8, 2025
commit cfb02c7e43e68238497f0325460ae989c88ed072
3 changes: 0 additions & 3 deletions provisioner/terraform/resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,9 +1334,6 @@ func TestMetadata(t *testing.T) {
require.Len(t, state.Resources[0].Metadata, 1)
require.Equal(t, "test", state.Resources[0].Metadata[0].Key)
require.Equal(t, "value", state.Resources[0].Metadata[0].Value)

// When resource_id is not found, it falls back to graph traversal
// We can't easily verify the warning was logged without access to the log capture API
})
})
}
Expand Down