Skip to content

chore: pass previous values into terraform apply #17696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 12, 2025
Merged

chore: pass previous values into terraform apply #17696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d565cb5
chore: pass previous values into the terraform apply
Emyrk May 6, 2025
b6d3d67
update preview
Emyrk May 7, 2025
520fe49
make gen
Emyrk May 7, 2025
690daac
test: fix asserted test error text
Emyrk May 7, 2025
692bab8
remove from plan request
Emyrk May 7, 2025
81ad901
remove previous values from plan
Emyrk May 7, 2025
c917ab0
remove from plan request
Emyrk May 7, 2025
28b2b9f
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 9, 2025
3fb8a22
reset go.mod
Emyrk May 9, 2025
2b642a6
update preview
Emyrk May 9, 2025
fd6cdf5
update versions
Emyrk May 9, 2025
2b41b8f
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
8a0dab1
chore: add previous values to plan request
Emyrk May 12, 2025
d9fc4cc
make gen
Emyrk May 12, 2025
fb2f081
pass in previous values to the plan step
Emyrk May 12, 2025
97a99aa
pass previous values in workspace build
Emyrk May 12, 2025
9f3a8fd
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
bc38bfa
revert go mod changes
Emyrk May 12, 2025
a7ab88c
make gen
Emyrk May 12, 2025
52dcd80
Merge branch 'main' into stevenmasley/monotonic
Emyrk May 12, 2025
3eb22f4
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
cb0f145
gen
Emyrk May 12, 2025
2774c07
make gen
Emyrk May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove from plan request
  • Loading branch information
@Emyrk
Emyrk committed May 7, 2025
commit 692bab83f4aaf18bfd3690db507ed1e1ee8549ed
1 change: 0 additions & 1 deletion provisionersdk/proto/provisioner.proto
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update provisionerd/proto/version.go when changes to this file are made.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this. There is another change that bumped to v1.5 today. So I'm joining that minor version bump.

Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ message PlanRequest {
repeated RichParameterValue rich_parameter_values = 2;
repeated VariableValue variable_values = 3;
repeated ExternalAuthProvider external_auth_providers = 4;
repeated RichParameterValue previous_parameter_values = 5;
}

// PlanComplete indicates a request to plan completed.
Expand Down
6 changes: 6 additions & 0 deletions tailnet/proto/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ import (
// PushResourcesMonitoringUsage RPCs on the Agent API.
// - Added support for reporting connection events for auditing via the
// ReportConnection RPC on the Agent API.
//
// API v2.5:
// - Shipped in Coder v2.{{placeholder}} // TODO Steven: Replace with the correct version
// - Add previous parameter values to 'WorkspaceBuild' jobs. Provisioner passes
// the previous values for the `terraform apply` to enforce monotonicity
// in the terraform provider.
const (
CurrentMajor = 2
CurrentMinor = 5
Expand Down
Loading