Skip to content

test: Invalid error scope caused race in WorkspaceHistoryLogs #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Feb 4, 2022

I'm dumbfounded CI didn't catch this earlier!

@kylecarbs kylecarbs self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #164 (726edfd) into main (682238d) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   65.41%   65.50%   +0.08%     
==========================================
  Files         106      106              
  Lines        5580     5580              
  Branches       68       68              
==========================================
+ Hits         3650     3655       +5     
+ Misses       1573     1570       -3     
+ Partials      357      355       -2     
Flag Coverage Δ
unittest-go-macos-latest 62.73% <ø> (-0.03%) ⬇️
unittest-go-ubuntu-latest 64.45% <ø> (+0.06%) ⬆️
unittest-go-windows-latest 62.34% <ø> (?)
unittest-js 64.21% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/listen.go 82.40% <0.00%> (-2.40%) ⬇️
provisionerd/provisionerd.go 67.95% <0.00%> (-0.73%) ⬇️
peer/conn.go 80.51% <0.00%> (+1.02%) ⬆️
peer/channel.go 84.75% <0.00%> (+1.82%) ⬆️
peerbroker/dial.go 80.95% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682238d...726edfd. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, nice catch! I wonder if there is a lint rule that would help here?

@kylecarbs kylecarbs merged commit 7a7f664 into main Feb 4, 2022
@kylecarbs kylecarbs deleted the errrace branch February 4, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants