chore(coderd/database/gen/dump): add optional DB_DUMP_CONNECTION_URL #16243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Jan 23, 2025
johnstcn
approved these changes
Jan 23, 2025
Comment on lines
+75
to
+79
| - PostgreSQL 13 (optional if Docker is available) | ||
| - *Note*: If you are using Docker, you can skip this step | ||
| - on macOS, run `brew install postgresql@13` and `brew services start postgresql@13` | ||
| - To enable schema generation with non-containerized PostgreSQL, set the following environment variable: | ||
| - `export DB_DUMP_CONNECTION_URL="postgres://postgres@localhost:5432/postgres?password=postgres&sslmode=disable"` |
There was a problem hiding this comment.
Maybe add a warning note regarding pg_dump version compatibility:
DB_DUMP_CONNECTION_URL='postgresql://user:pass@ds918.home:5433/coder_tmp?sslmode=disable' make gen
pg_dump: error: server version: 16.2 (Debian 16.2-1.pgdg120+2); pg_dump version: 13.18
pg_dump: error: aborting because of server version mismatch
panic: dump schema failed: exit status 1
goroutine 1 [running]:
main.main()
/Users/cian/src/coder/coder/coderd/database/gen/dump/main.go:70 +0x354
exit status 2
make: *** [Makefile:618: coderd/database/dump.sql] Error 1
There was a problem hiding this comment.
I think this is an unlikely scenario, you can use pg_dump@16 with postgresql@13 but not vice-versa as you saw here. Since we're advising to use an older postgresql server here, you'd really have to make an effort to use an even older pg_dump 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the DB dump to be performed without Docker, BYODB.