Skip to content

chore: remove href from external auth flow, href opened in new window #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 13, 2024

Closes #12581

The opened window in window.open handles the auth flow. We do not need the button to redirect the current page.

@Emyrk Emyrk changed the title chore: external auth flow opens new window, it does not need an href chore: remove href from external auth flow, href opened in new window Mar 13, 2024
@sreya sreya requested a review from aslilac March 14, 2024 00:54
@Emyrk Emyrk merged commit 410a7d5 into main Mar 14, 2024
@Emyrk Emyrk deleted the stevenmasley/ext_id_use_popup branch March 14, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: external auth button redirects the primary coder page, not just the pop-up
2 participants