chore: log with %s on unexpected non-sdk err (#20570)

code-asher · web-flow · commit d306a2d7e571 · 2025-10-30T10:23:52.000-08:00
With `%w` it prints an address instead of the error, like `<op> <url> 0xc001329370` instead of `<op> <url>: some error`, honestly idk why you even can log with `%w` it seems like it makes no sense to use `%w` outside of `fmt.Errorf`. This is to help debug coder/internal#1010.
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -1604,7 +1604,7 @@ func (nopcloser) Close() error { return nil }
 // SDKError coerces err into an SDK error.
 func SDKError(t testing.TB, err error) *codersdk.Error {
 	var cerr *codersdk.Error
-	require.True(t, errors.As(err, &cerr), "should be SDK error, got %w", err)
+	require.True(t, errors.As(err, &cerr), "should be SDK error, got %s", err)
 	return cerr
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1604,7 +1604,7 @@ func (nopcloser) Close() error { return nil }`
`1604`	`1604`	`// SDKError coerces err into an SDK error.`
`1605`	`1605`	`func SDKError(t testing.TB, err error) *codersdk.Error {`
`1606`	`1606`	`var cerr *codersdk.Error`
`1607`		`- require.True(t, errors.As(err, &cerr), "should be SDK error, got %w", err)`
	`1607`	`+ require.True(t, errors.As(err, &cerr), "should be SDK error, got %s", err)`
`1608`	`1608`	`return cerr`
`1609`	`1609`	`}`
`1610`	`1610`