Skip to content

flake: TestEditFiles/RelativePath #1010

@blink-so

Description

@blink-so

Appears to affect all MCP file tools that have a relative path test. TestReadFile/RelativePath and TestEditFiles/RelativePath seen so far. Also seems to affect other subtests (TestEditFiles/NoPermissions, TestEditFiles/NoEdits), so it seems like some generic issue with making requests to the agent?

CI Run

GitHub Actions Log

Error Analysis

=== FAIL: agent TestEditFiles/RelativePath (25.00s)
    coderdtest.go:1592:
        	Error Trace:	C:/actions-runner/coder/coder/coderd/coderdtest/coderdtest.go:1592
        						C:/actions-runner/coder/coder/agent/files_test.go:707
        	Error:      	Should be true
        	Test:       	TestEditFiles/RelativePath
        	Messages:   	should be SDK error, got %!w(*xerrors.wrapError=&{do request 0xc0073c9140 {[140702362032838 140702377576688 140702395248547]}})
--- FAIL: TestEditFiles/RelativePath (25.00s)
FAIL	github.com/coder/coder/v2/agent	27.833s

Root Cause Assessment

  • Test Function: TestEditFiles in agent/files_test.go:390-722
  • Failing subtest: RelativePath (line 461)
  • Error location: Line 707 calling coderdtest.SDKError(t, err)
  • Platform: Windows (test-go-pg windows-2022)
  • Pattern: Same coderdtest.go:1592 error as seen in issue flake: TestReadFile/RelativePath #982 (TestReadFile/RelativePath)
  • No data races or panics detected

Assignment Analysis

Git blame results: The entire TestEditFiles function was authored by Asher (code-asher) on 2025-09-12 in commit 30330abaea.

Commit Info

  • SHA: 0601cc8fa623f0dd4e44274f08271cc748ff26d9
  • Author: Asher (code-asher)
  • Related Issues: Similar to flake: TestReadFile/RelativePath #982 with same error pattern, suggesting systematic issue with SDK error handling in Windows CI

Reproduction Steps

This appears to be a Windows-specific timing or SDK error handling issue. The test expects an SDK error but receives a different error wrapper type.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions