fix: openai blocking requests do not call injected tools correctly #72
+62
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
96729ce to
68cf38a
Compare
SasSwart
approved these changes
Dec 5, 2025
Collaborator
Author
It was used: Thanks for the review 👍 |
pawbana
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #63 @pawbana uncovered a latent bug in the OpenAI non-streaming interception handler. When injected tools are invoked, arguments are not being supplied correctly to the MCP invocation. The JSON unmarshaling was silently failing, and the code in general was brittle.
This also exposed a shortcoming in the tests whereby we'd just validate that the injected tool invocation was recorded (along with its args) but not that the actual MCP tool call took place! I've added a
callAccumulatortype which will track these invocations for testing.