feat(codemod-sandbox): integrate OxcResolver for module resolution #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR integrates OxcResolver to replace the previous FileSystemResolver for module resolution in codemod-sandbox. The integration adds TypeScript-aware module resolution with support for tsconfig.json path mapping and Node.js-style module resolution.
- Replaces FileSystemResolver with OxcResolver throughout the codebase
- Adds automatic tsconfig.json discovery functionality
- Removes the loader abstraction layer as it's no longer needed with the new resolver
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/core/src/engine.rs | Updated to use OxcResolver with tsconfig discovery |
| crates/codemod-sandbox/src/sandbox/resolvers/oxc_resolver.rs | New OxcResolver implementation with comprehensive TypeScript support |
| crates/codemod-sandbox/src/utils/project_discovery.rs | New utility for finding tsconfig.json files |
| crates/codemod-sandbox/src/sandbox/engine/execution_engine.rs | Updated to remove loader dependency and use ModuleResolver generically |
| crates/cli/src/commands/jssg/run.rs | Updated command handlers to use OxcResolver |
Comments suppressed due to low confidence (2)
crates/codemod-sandbox/src/sandbox/resolvers/oxc_resolver.rs:222
- The test uses a hardcoded /tmp path which may not exist or be writable on all systems. Consider using tempfile::TempDir for more robust cross-platform testing.
let base_dir = PathBuf::from("/tmp");
crates/core/src/engine.rs:1376
- [nitpick] The error message 'Failed to create OxcResolver' could be more specific about what went wrong during resolver creation, such as whether it was a tsconfig parsing issue or a filesystem error.
.map_err(|e| Error::Other(format!("Failed to create OxcResolver: {e}")))?,
commit: |
43e78e3 to
50e060f
Compare
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
🔗 Linked Issue
🧪 Test Plan
📄 Documentation to Update