Post Issuance Check: Certificate's AdditionalOutputFormats #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahrlin
reviewed
Feb 7, 2022
Contributor
jahrlin
left a comment
There was a problem hiding this comment.
LGTM but for the two comments describing the policy checks
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
value in /devel/run-e2e.sh Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
27901ac to
f932e80
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f932e80 to
19b68c9
Compare
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Contributor
|
Thanks @JoshVanL! /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two Post Issuances checks which are carried out by the secrets manager (issuing controller). Together, they verify that the Certificate's
AdditionalOutputFormatsare correctly reflected on the target secret; they only exist if they should, they contain the correct values, and they must exist if defined on the Certificate.As the same with the Certificate's
SecretTemplate, any violation to the rule will have the Secret re-applied, and the correct key/values added/removed/modified.These checks are not gated behind a feature gate. They don't need to be- the API is only available when that feature gate is enabled. If somehow the Certificate does contain
AdditionalOutputFormatswhen the feature gate is disabled, any violation would cause a re-apply of the Secret and the resulting state reflects no output formats (since the gate is disabled). Any further re-reconcile will not cause a loop- since applying with no state changes does not cause a informer event./kind feature
/milestone v1.8
/area api