Fix/include parent referenced fields in subqueries #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extract_parent_referenced_fields/1 function to analyze filter expressions and identify fields referenced through parent() calls. This will be used to ensure these fields are available in subqueries when aggregates use parent filters.
zachdaniel
requested changes
Nov 1, 2025
| |> Enum.uniq() | ||
| end | ||
|
|
||
| defp extract_refs_from_expr(attribute) |
Contributor
There was a problem hiding this comment.
Unfortunately I don't think that this is quite enough. The aggregate could reference calculations which themselves reference fields etc.
I think the fix is to select everything in the subquery and then only select the appropriate fields when selecting from the subquery. Which TBH is a bit harder and I'm not entirely sure what the best path is.
You could possibly extract the field names selected from the underlying built query's select expr, then select merge all attributes, then select from the subquery the field names you originally got.
Contributor
|
Fixed and released the modified strategy I discussed 🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix ash-project/ash_postgres#644
I cloned it locally and the test passes now on my machine
Contributor checklist
Leave anything that you believe does not apply unchecked.